Skip to content

Bug: mpas compute_u_with_rbf returns the last ensemble member value for the whole esemble #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hkershaw-brown opened this issue Apr 23, 2025 · 0 comments
Open

Bug: mpas compute_u_with_rbf returns the last ensemble member value for the whole esemble #861

hkershaw-brown opened this issue Apr 23, 2025 · 0 comments
Labels
Bug Something isn't working mpas Model for Prediction Across Scales (MPAS)

Comments

@hkershaw-brown
Copy link
Member

Originally noted in #753

In compute_u_with_rbf there is a loop around ens_size, for get_reconstruct but uval(1:ens_size) is set to set to the single value ureconstructzonal/ureconstructmeridional so you are getting the whole ensemble set each step of the loop

whole ensemble == last value from the loop.

DART/models/mpas_atm/model_mod.f90

Lines 6214 to 6226 in e218864

do e = 1, ens_size
call get_reconstruct(nedges, lat*deg2rad, lon*deg2rad, &
coeffs_reconstruct, on_a_sphere, veldata(:, e), &
ureconstructx, ureconstructy, ureconstructz, &
ureconstructzonal, ureconstructmeridional)
if (zonal) then
uval = ureconstructzonal
else
uval = ureconstructmeridional
endif
enddo

Originally posted by @hkershaw-brown in #753
@hkershaw-brown hkershaw-brown changed the title Bug: mpas compute_u_with_rbf sets returns the last ensemble member value for the whole esemble Bug: mpas compute_u_with_rbf returns the last ensemble member value for the whole esemble Apr 23, 2025
@hkershaw-brown hkershaw-brown added Bug Something isn't working mpas Model for Prediction Across Scales (MPAS) labels Apr 23, 2025
@hkershaw-brown hkershaw-brown mentioned this issue Apr 24, 2025
Open
15 tasks
hkershaw-brown added a commit that referenced this issue May 23, 2025
@hkershaw-brown
depricate use_u_for_wind, wind documentation
ce322d9 
On advice from jla: error if a user has selected use_u_for_wind
as there is a bug in Manhattan, where all ensemble members are set to
the last ensemble member value in the rbf calculation
#861

Documentation for mpas regristry changes needed for DART

Regional wind updates namelist options in update_bc - not sure whey
they do not use the same model_nml options, so not added to docs in
this commit.
hkershaw-brown added a commit that referenced this issue May 23, 2025
@hkershaw-brown
depricate use_u_for_wind, wind documentation
aa5435e 
On advice from jla: error if a user has selected use_u_for_wind
as there is a bug in Manhattan, where all ensemble members are set to
the last ensemble member value in the rbf calculation
#861
see #780 (comment)

Documentation for mpas regristry changes needed for DART

Regional wind updates namelist options in update_bc - not sure whey
they do not use the same model_nml options, so not added to docs in
this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working mpas Model for Prediction Across Scales (MPAS)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkershaw-brown