Skip to content

Commit 37d7176

Browse files
authored
Merge pull request #634 from NDLANO/allow-whitespace-in-url-validation
Gjør at validering av url i embed ikkje feiler ved lagring.
2 parents 17e22de + 89e4415 commit 37d7176

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

validation/src/main/scala/no/ndla/validation/HtmlTagRules.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import org.jsoup.nodes.Element
1414
import org.jsoup.nodes.Entities.EscapeMode
1515

1616
import scala.io.Source
17-
import scala.jdk.CollectionConverters._
17+
import scala.jdk.CollectionConverters.*
1818

1919
object HtmlTagRules {
2020

validation/src/main/scala/no/ndla/validation/TagValidator.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ object TagValidator {
573573
if (!field.validation.required && value.isEmpty) {
574574
return None
575575
}
576-
if (value.matches(domainRegex)) {
576+
if (value.trim.matches(domainRegex)) {
577577
if (field.validation.allowedDomains.isEmpty) None
578578
else {
579579
val urlHost = value.hostOption.map(_.toString).getOrElse("")

validation/src/main/scala/no/ndla/validation/TextValidator.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ object TextValidator {
7676
allowedTags: Set[String]
7777
): Seq[ValidationMessage] = {
7878

79-
val whiteList = new Safelist().addTags(allowedTags.toSeq: _*)
79+
val whiteList = new Safelist().addTags(allowedTags.toSeq*)
8080
HtmlTagRules.allLegalTags
8181
.filter(tag => HtmlTagRules.legalAttributesForTag(tag).nonEmpty)
82-
.foreach(tag => whiteList.addAttributes(tag, HtmlTagRules.legalAttributesForTag(tag).toSeq: _*))
82+
.foreach(tag => whiteList.addAttributes(tag, HtmlTagRules.legalAttributesForTag(tag).toSeq*))
8383

8484
if (text.isEmpty) {
8585
Seq.empty

validation/src/test/scala/no/ndla/validation/UnitSuite.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
package no.ndla.validation
1010

11-
import org.scalatest._
11+
import org.scalatest.*
1212
import org.scalatest.funsuite.AnyFunSuite
1313
import org.scalatest.matchers.should.Matchers
1414

0 commit comments

Comments
 (0)