-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show user notifications for "queried" records and verifier comments #242
Comments
Of the two points above, alerting users to queries is the highest priority; displaying verification comments would also be valuable but is less important that the queries. @kitenetter to clarify data structure for flagging queries and check with JvB whether this is yet available in ES; verifier comments would also need to be added to ES |
It is already possible to search for queried records in Elasticsearch ( |
@johnvanbreda, at some point, we might want to allow users to leave comments on records in the app. Is there a REST endpoint that would allow us to read and write comments? |
@kitenetter I have added the queried record statuses to the iRecord App. Can you check if it works OK for your account in the demo app? |
@kazlauskis I've tested that and the query was correctly displayed in the app. I have taken some screenshots and will add some Help text. For the link to the iRecord website, you are currently using the "Edit record" view. However, in that view you cannot see the query that has been added. So I think the link should go to the "View record" view. For example, the record I queried has the link going to: I think it is better if it goes to: |
@kitenetter OK, I'll change that. Do you know if there are other such "view" pages for the other three surveys the app has? Also, it is worth pointing out that changing the occurrence query status by leaving a comment doesn't automatically show a message in the app. The app uses the |
@kazlauskis my understanding is that all occurrences from surveys that are linked to the iRecord website will be viewable via a 'view' page, so the app survey records should be viewable in that way. The comment I added to my test record was done by adding a query, and that is the correct behaviour as far as I'm concerned. I don't think a verifier would ever mark a record as queried without also adding a comment, but as long as the queried flag is being picked up the comment should be there when the user views the record on iRecord. I would not expect an app user to be notified if a non-verifier added a comment to a record (that can happen, but it is the verifier queries that we are trying to address here). |
Thanks, the disabled record message with the link to iRecord is on every "main" survey page, i.e. the first page you open within a survey. This works well for the general survey, but other surveys have sub-samples, and occurrences are shown within a list. I was wondering if those other surveys had something similar to the |
As far as I'm aware, the Our current tools for viewing and editing sub-samples on the iRecord website are difficult to use, and need a review and upgrade, but we don't yet have that work scheduled in. |
A follow up from #240. At the moment, the app only shows verification updates for verified, rejected and possible states.
Add verification comments to ElasticSearch.(outside the current scope)The text was updated successfully, but these errors were encountered: