Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species filters: select all/unselect all and other edit #289

Open
sacrevert opened this issue Sep 4, 2024 · 4 comments
Open

Species filters: select all/unselect all and other edit #289

sacrevert opened this issue Sep 4, 2024 · 4 comments
Milestone

Comments

@sacrevert
Copy link
Collaborator

Having these options would make life easier I think. Currently a pain for generally having a small number selected, but then wanting to record a species outside of those -- you either have to know the exact group (sometimes easy, sometimes not), or go through switching them all on. Also would make bug testing easier across groups!

Note that if we change the display of names so that common and scientific names are shown together at all times, then we will probably want to amend the options given here relating to scientific and common name searches too (remove them e.g.).

@sacrevert sacrevert added this to the 6.2.0 milestone Sep 4, 2024
@sacrevert sacrevert assigned kazlauskis and unassigned kazlauskis Sep 4, 2024
@kitenetter
Copy link
Collaborator

I don't see a problem with keeping the radio button choices for the three name options:

  • Default (= both English and scientific)
  • Common only [is this actually the same as saying English, or do we allow vernacular names in other languages in the app?]
  • Scientific only

@sacrevert
Copy link
Collaborator Author

sacrevert commented Sep 4, 2024

I suppose we could. Personally I would think always showing both and limiting it to that would reduce errors overall and generally be educational (in both directions), but I suppose if we want to give people the option to reduce the information content of the display then ok.

@sacrevert
Copy link
Collaborator Author

I don't see a problem with keeping the radio button choices for the three name options:

  • Default (= both English and scientific)
  • Common only [is this actually the same as saying English, or do we allow vernacular names in other languages in the app?]
  • Scientific only

Actually, won't this conflict with the request here to always include both scientific and common together (#183)? On thinking about this further, I have a very strong preference for not allowing users to only use common names, as this opens up the opportunity for lots of errors. Since writing the above it has also come to my attention that a number of rare alien plants have ambiguous common names in the UKSI, and, short of updating every ambiguous common name in the UKSI, I think it far better to always present scientific and common names together (although we could allow scientific only of course, as that is a lot less ambiguous).

@sacrevert
Copy link
Collaborator Author

This may not matter if we always display scientific and common names together, but there is currently a bug relating to these filters. If you have either scientific or common name filtering selected, and type the wrong type of search string, and then change filtering to the correct type, no hits are returned. For example:

  • Have filter on common names setting
  • search for Bellis (a scientific name)
  • leave Bellis in search box and change filter to scientific
  • close filter screen
  • Bellis still doesn't show hits without retyping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants