From e5e71b7907a702e2b2b35c00af8fb9811e059f74 Mon Sep 17 00:00:00 2001
From: matthew pyle <Matthew.Pyle@noaa.gov>
Date: Tue, 14 Jan 2025 16:21:22 +0000
Subject: [PATCH] Attempt at adding POSTPROC_SUBH_LEN_HRS variable to control
 how long to apply the 15 minute aggregating within exrrfs_post.sh

---
 parm/config/det/var_defns.sh                  | 4 ++++
 scripts/exrrfs_post.sh                        | 2 +-
 ush/config_defaults.sh                        | 4 ++++
 ush/generate_FV3LAM_wflow.sh                  | 1 +
 ush/sample_configs/RRFS_A/config.sh_rrfs_a_n3 | 1 +
 5 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/parm/config/det/var_defns.sh b/parm/config/det/var_defns.sh
index 235bea462..cc9aa3e4f 100644
--- a/parm/config/det/var_defns.sh
+++ b/parm/config/det/var_defns.sh
@@ -585,6 +585,9 @@ WFLOW_LAUNCH_LOG_FN="log.launch_FV3LAM_wflow"
 # POSTPROC_LONG_LEN_HRS:
 # The length of long post process, in integer hours.
 #
+# POSTPROC_SUBH_LEN_HRS:
+# The length of subhourly product generation, in integer hours.
+#
 # CYCL_HRS_HYB_FV3LAM_ENS:
 # An array containing the hours of the day at which the GSI hybrid using
 # FV3LAM ensemeble.
@@ -630,6 +633,7 @@ BOUNDARY_LONG_LEN_HRS="0"
 BOUNDARY_PROC_GROUP_NUM="72"
 POSTPROC_LEN_HRS="18"
 POSTPROC_LONG_LEN_HRS="60"
+POSTPROC_SUBH_LEN_HRS="18"
 FCST_LEN_HRS="18"
 FCST_LEN_HRS_SPINUP="1"
 FCST_LEN_HRS_CYCLES=( \
diff --git a/scripts/exrrfs_post.sh b/scripts/exrrfs_post.sh
index a60802d10..89560fb81 100755
--- a/scripts/exrrfs_post.sh
+++ b/scripts/exrrfs_post.sh
@@ -139,7 +139,7 @@ if [ ${len_fhr} -eq 9 ]; then
   post_min=${fhr:4:2}
   if [ ${post_min} -lt ${nsout_min} ]; then
     post_min=00
-	  if [ $post_fhr -gt 1 -a $post_fhr -le 018 ]
+	  if [ $post_fhr -ge 1 -a $post_fhr -le $POSTPROC_SUBH_LEN_HRS ]
 	  then
           SUBH_GEN=1
 	  fi
diff --git a/ush/config_defaults.sh b/ush/config_defaults.sh
index dd9c73866..9adb5b207 100644
--- a/ush/config_defaults.sh
+++ b/ush/config_defaults.sh
@@ -583,6 +583,9 @@ WFLOW_LAUNCH_LOG_FN="log.launch_FV3LAM_wflow"
 # POSTPROC_LONG_LEN_HRS:
 # The length of long post process, in integer hours.
 #
+# POSTPROC_SUBH_LEN_HRS:
+# The number of hours (integer) for which subhourly output is generated
+#
 # CYCL_HRS_HYB_FV3LAM_ENS:
 # An array containing the hours of the day at which the GSI hybrid using 
 # FV3LAM ensemeble.
@@ -610,6 +613,7 @@ BOUNDARY_LONG_LEN_HRS="0"
 BOUNDARY_PROC_GROUP_NUM="1"
 POSTPROC_LEN_HRS="1"
 POSTPROC_LONG_LEN_HRS="1"
+POSTPROC_SUBH_LEN_HRS="0"
 FCST_LEN_HRS="24"
 FCST_LEN_HRS_SPINUP="1"
 FCST_LEN_HRS_CYCLES=()
diff --git a/ush/generate_FV3LAM_wflow.sh b/ush/generate_FV3LAM_wflow.sh
index ee0ae3e6f..ead9155f5 100755
--- a/ush/generate_FV3LAM_wflow.sh
+++ b/ush/generate_FV3LAM_wflow.sh
@@ -443,6 +443,7 @@ settings="\
   'boundary_long_len_hrs': ${BOUNDARY_LONG_LEN_HRS}
   'postproc_len_hrs': ${POSTPROC_LEN_HRS}
   'postproc_long_len_hrs': ${POSTPROC_LONG_LEN_HRS}
+  'postproc_subh_len_hrs': ${POSTPROC_SUBH_LEN_HRS}
   'postproc_nsout_min': ${NSOUT_MIN}
   'postproc_nfhmax_hrs': ${NFHMAX_HF}
   'postproc_nfhout_hrs': ${NFHOUT}
diff --git a/ush/sample_configs/RRFS_A/config.sh_rrfs_a_n3 b/ush/sample_configs/RRFS_A/config.sh_rrfs_a_n3
index b18712cca..a95bc1bf0 100644
--- a/ush/sample_configs/RRFS_A/config.sh_rrfs_a_n3
+++ b/ush/sample_configs/RRFS_A/config.sh_rrfs_a_n3
@@ -84,6 +84,7 @@ RESTART_INTERVAL_LONG="1 2 12 24 36 48"
 ## set up post
 POSTPROC_LEN_HRS="18"
 POSTPROC_LONG_LEN_HRS="60"
+POSTPROC_SUBH_LEN_HRS="18"
 
 # default 
 OUTPUT_FH="1 -1"