Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind file reader requires data not used by wind power model. #2019

Open
cpaulgilman opened this issue Feb 21, 2025 · 0 comments
Open

Wind file reader requires data not used by wind power model. #2019

cpaulgilman opened this issue Feb 21, 2025 · 0 comments
Assignees
Labels
dev bug Internal bug that should not be included in release notes

Comments

@cpaulgilman
Copy link
Collaborator

Describe the bug

The wind resource file reader lib_windfile.cpp requires time zone and elevation data that is not used by the wind power model.

Elevation data does not appear to be used in any wind power model calculations, but may be required for SAM UI calculations -- need to investigate the elevation requirement. If it is only a UI requirement, handle missing data in UI when it applies instead of in SSC. (Elevation not included in WIND Toolkit wtk-download data.)

No need to require lat/lon data: The only potential use of lat/lon data in a wind file would be for hybrid systems to verify that the wind and solar wind files are for the same location, but this is not something we plan to have the hybrid models check or enforce. (Solar models need lat/lon for sun position calculations that are not needed for wind power model.)

Files for testing with missing elevation, timezone, and lat/lon data: wtk-download-default-no-elevation.zip

Operating System and Version

  • Windows 11
  • SAM Dev (Patch 2/21/2025)
@cpaulgilman cpaulgilman self-assigned this Feb 21, 2025
@cpaulgilman cpaulgilman added dev bug Internal bug that should not be included in release notes and removed bug labels Feb 21, 2025
@cpaulgilman cpaulgilman added this to the 2024 Release Patch 1 milestone Feb 21, 2025
@janinefreeman janinefreeman modified the milestones: 2024 Release Patch 1, SAM Fall 2025 Release Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev bug Internal bug that should not be included in release notes
Projects
None yet
Development

No branches or pull requests

2 participants