Problem
tests/recipes/omni3/test_cli.py fails to collect because it imports from nemotron.cli.commands.omni3.build:
ModuleNotFoundError: No module named 'nemotron.cli.commands.omni3.build'
The test references several symbols that are expected to exist in that module:
from nemotron.cli.commands.omni3.build import (
BUILD_IMAGE,
REMOTE_CODE_ROOT,
STAGES,
STAGE_ALIASES,
_make_build_script,
)
However, src/nemotron/cli/commands/omni3/ does not contain a build.py file.
Context
Searching the repo shows these symbols are only referenced in tests/recipes/omni3/test_cli.py itself — they do not exist anywhere in src/. This suggests either:
- The
build.py module was removed or renamed, and the test is stale.
- The
build.py module was never committed, and the test was added prematurely.
- The build functionality moved to a different location (e.g.,
nemo_runspec or another recipe directory) and the test imports were not updated.
Question
How should this be resolved? Options include:
- Remove or skip
tests/recipes/omni3/test_cli.py if it is no longer valid.
- Implement the missing
nemotron/cli/commands/omni3/build.py module.
- Update the test to import from the correct location if the code moved elsewhere.
Happy to open a PR once the intended direction is clear.
Problem
tests/recipes/omni3/test_cli.pyfails to collect because it imports fromnemotron.cli.commands.omni3.build:The test references several symbols that are expected to exist in that module:
However,
src/nemotron/cli/commands/omni3/does not contain abuild.pyfile.Context
Searching the repo shows these symbols are only referenced in
tests/recipes/omni3/test_cli.pyitself — they do not exist anywhere insrc/. This suggests either:build.pymodule was removed or renamed, and the test is stale.build.pymodule was never committed, and the test was added prematurely.nemo_runspecor another recipe directory) and the test imports were not updated.Question
How should this be resolved? Options include:
tests/recipes/omni3/test_cli.pyif it is no longer valid.nemotron/cli/commands/omni3/build.pymodule.Happy to open a PR once the intended direction is clear.