Skip to content

tests: tests/recipes/omni3/test_cli.py imports missing nemotron.cli.commands.omni3.build module #284

Description

@andrewwhitecdw

Problem

tests/recipes/omni3/test_cli.py fails to collect because it imports from nemotron.cli.commands.omni3.build:

ModuleNotFoundError: No module named 'nemotron.cli.commands.omni3.build'

The test references several symbols that are expected to exist in that module:

from nemotron.cli.commands.omni3.build import (
    BUILD_IMAGE,
    REMOTE_CODE_ROOT,
    STAGES,
    STAGE_ALIASES,
    _make_build_script,
)

However, src/nemotron/cli/commands/omni3/ does not contain a build.py file.

Context

Searching the repo shows these symbols are only referenced in tests/recipes/omni3/test_cli.py itself — they do not exist anywhere in src/. This suggests either:

  1. The build.py module was removed or renamed, and the test is stale.
  2. The build.py module was never committed, and the test was added prematurely.
  3. The build functionality moved to a different location (e.g., nemo_runspec or another recipe directory) and the test imports were not updated.

Question

How should this be resolved? Options include:

  1. Remove or skip tests/recipes/omni3/test_cli.py if it is no longer valid.
  2. Implement the missing nemotron/cli/commands/omni3/build.py module.
  3. Update the test to import from the correct location if the code moved elsewhere.

Happy to open a PR once the intended direction is clear.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions