Skip to content

feat(embed): update default embedding profile#291

Merged
shan-nvidia merged 36 commits into
mainfrom
oholworthy/embed-finetune-recipe-2607
Jul 15, 2026
Merged

feat(embed): update default embedding profile#291
shan-nvidia merged 36 commits into
mainfrom
oholworthy/embed-finetune-recipe-2607

Conversation

@oliverholworthy

@oliverholworthy oliverholworthy commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the existing embed recipe's default profile for the new embedding model family, including isolated artifacts and checkpoint compatibility checks.
  • Keep the existing legacy profile available for training and deployment workflows.
  • Add direct consolidated-checkpoint deployment with Retriever NIM 2.1 and vLLM; vLLM evaluation uses /v2/embed with input_type.
  • Protect SDG API keys from saved configuration, CLI provenance, and remote Slurm job output.
  • Refresh profile-aware documentation and reproducible stage lockfiles.

Why

The previous default profile was coupled to its export-based serving contract. This update makes the new default use the native checkpoint path through NIM or vLLM, while retaining the prior profile for existing users.

Validation

  • uv run pytest tests/recipes/embed -q --basetemp=/tmp/nemotron-final-public-review — 278 passed, 4 skipped
  • Shared executor and SDG regression coverage — 106 passed
  • Root and changed stage uv lock --check validations passed
  • Live Retriever NIM 2.1 smoke: readiness plus query and passage embeddings, both 2,048 dimensions
  • Final diff hygiene and credential scan completed; no literal credentials found

Review note

Stage 2 currently pins the source archive commit a9f4423819c513fd08083324fe1f738746ac6e54 from Automodel PR #3021. That PR remains draft/open, so this PR stays draft pending the dependency's merge or an explicit preview-release decision.

@oliverholworthy oliverholworthy self-assigned this Jul 14, 2026
@oliverholworthy oliverholworthy added the enhancement New feature or request label Jul 14, 2026
@oliverholworthy oliverholworthy changed the title feat(embed): add embedding fine-tuning recipe feat(embed): update default embedding profile Jul 14, 2026
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Restore EVAL.md from upstream/main and adopt the agentskills.io wrapper without changing existing case semantics.

Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
@oliverholworthy
oliverholworthy force-pushed the oholworthy/embed-finetune-recipe-2607 branch from 29bb9bb to aa83449 Compare July 15, 2026 11:06
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
@oliverholworthy
oliverholworthy marked this pull request as ready for review July 15, 2026 17:18
@oliverholworthy

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
@oliverholworthy

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
@oliverholworthy

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

svc-nvskills-signing and others added 2 commits July 15, 2026 21:04
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

@shan-nvidia shan-nvidia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shan-nvidia
shan-nvidia merged commit 2a68716 into main Jul 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants