Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Platforms to manage the toolchains #18

Closed
narendasan opened this issue Aug 5, 2019 · 2 comments
Closed

Use Platforms to manage the toolchains #18

narendasan opened this issue Aug 5, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@narendasan
Copy link
Member

We should move to using platforms (https://docs.bazel.build/versions/master/platforms.html) and toolchains (https://docs.bazel.build/versions/master/toolchains.html) as soon as the rules are stable so that we can version the toolchains between PDK versions. A hacky version of this is already in for linux. Should also address #14

@narendasan narendasan added the good first issue Good for newcomers label Aug 5, 2019
@ZhenshengLee
Copy link

Currently, the toolchains is already being used to cross-compile for different target arch and sdk.

But the platforms has not already being used because I just see codes which are commented.

DL4AGX/toolchains/BUILD

Lines 20 to 46 in 3dad2b9

# constaint_setting(name = "gcc_version")
# constraint_value(
# name = "gcc_5.4",
# constaint_setting = ":gcc_version"
# )
# constraint_value(
# name = "gcc_7.4",
# constaint_setting = ":gcc_version"
# )
# constaint_setting(name = "qnx_version")
# constraint_value(
# name = "qnx_7.0.0",
# constaint_setting = ":qnx_version"
# )
# platform(
# name = "drive_pdk_5.1.3.0+linux",
# constaint_values = {
# "@platforms//os:linux",
# "@platforms//cpu:aarch64",
# ":gcc_5.4",
# ],
# )

@narendasan would you give this project any updates?

@chengzhe-xu
Copy link
Collaborator

Close this issue since the topic is no longer relevant. Feel free to re-open it if you still need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants