Skip to content

Commit a19bda8

Browse files
committed
fix(bootstrap): treat zero-valued no-progress override as unset
OPENSHELL_BUILD_NO_PROGRESS_TIMEOUT_SECS=0 previously parsed cleanly into Duration::from_secs(0), making every build fail immediately with "produced no output for 0s". Filter zero alongside non-numeric values so it falls back to the default. Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
1 parent 72cabb4 commit a19bda8

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

crates/openshell-bootstrap/src/build.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ async fn build_image(
116116
let no_progress_secs: u64 = std::env::var("OPENSHELL_BUILD_NO_PROGRESS_TIMEOUT_SECS")
117117
.ok()
118118
.and_then(|s| s.parse().ok())
119+
.filter(|&n| n > 0)
119120
.unwrap_or(DEFAULT_BUILD_NO_PROGRESS_TIMEOUT_SECS);
120121
let no_progress_timeout = Duration::from_secs(no_progress_secs);
121122

0 commit comments

Comments
 (0)