Skip to content

Commit bbc878b

Browse files
committed
docs(gateway): clarify OPENSHELL_GRPC_ENDPOINT applies to all drivers
The previous comment implied the callback endpoint was Kubernetes-only, but the value is propagated to every compute driver (Kubernetes, Docker, Podman, VM) and must be reachable from wherever the sandbox runs.
1 parent 21dbfb9 commit bbc878b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

  • crates/openshell-server/src

crates/openshell-server/src/cli.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,10 @@ struct RunArgs {
122122
#[arg(long, env = "OPENSHELL_SANDBOX_IMAGE_PULL_POLICY")]
123123
sandbox_image_pull_policy: Option<String>,
124124

125-
/// gRPC endpoint for sandboxes to callback to `OpenShell`.
126-
/// This should be reachable from within the Kubernetes cluster.
125+
/// gRPC endpoint that sandboxes use to call back into the gateway.
126+
/// Must be reachable from wherever the sandbox runs (Kubernetes pod,
127+
/// Docker/Podman container, or VM), and is applied to every compute
128+
/// driver.
127129
#[arg(long, env = "OPENSHELL_GRPC_ENDPOINT")]
128130
grpc_endpoint: Option<String>,
129131

0 commit comments

Comments
 (0)