Skip to content

Commit e00a00b

Browse files
committed
fix(sandbox): avoid similar proxy id names
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
1 parent a465f6f commit e00a00b

1 file changed

Lines changed: 15 additions & 10 deletions

File tree

  • crates/openshell-sandbox/src

crates/openshell-sandbox/src/main.rs

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -313,18 +313,18 @@ fn copy_sidecar_client_tls_if_present(
313313

314314
#[cfg(target_os = "linux")]
315315
fn run_network_init(
316-
network_proxy_uid: u32,
317-
network_proxy_gid: u32,
316+
proxy_user_id: u32,
317+
proxy_primary_group_id: u32,
318318
sidecar_state_dir: &str,
319319
sidecar_tls_dir: &str,
320320
) -> Result<()> {
321-
if network_proxy_uid < openshell_policy::MIN_SANDBOX_UID {
321+
if proxy_user_id < openshell_policy::MIN_SANDBOX_UID {
322322
return Err(miette::miette!(
323323
"--proxy-uid must be at least {}",
324324
openshell_policy::MIN_SANDBOX_UID
325325
));
326326
}
327-
if network_proxy_gid < openshell_policy::MIN_SANDBOX_UID {
327+
if proxy_primary_group_id < openshell_policy::MIN_SANDBOX_UID {
328328
return Err(miette::miette!(
329329
"--proxy-gid must be at least {}",
330330
openshell_policy::MIN_SANDBOX_UID
@@ -335,18 +335,23 @@ fn run_network_init(
335335
let sidecar_tls_dir = Path::new(sidecar_tls_dir);
336336
prepare_sidecar_directory(
337337
sidecar_state_dir,
338-
network_proxy_uid,
339-
network_proxy_gid,
338+
proxy_user_id,
339+
proxy_primary_group_id,
340340
0o775,
341341
)?;
342-
prepare_sidecar_directory(sidecar_tls_dir, network_proxy_uid, network_proxy_gid, 0o755)?;
342+
prepare_sidecar_directory(
343+
sidecar_tls_dir,
344+
proxy_user_id,
345+
proxy_primary_group_id,
346+
0o755,
347+
)?;
343348
copy_sidecar_client_tls_if_present(
344349
Path::new(CLIENT_TLS_DIR),
345350
sidecar_tls_dir,
346-
network_proxy_uid,
347-
network_proxy_gid,
351+
proxy_user_id,
352+
proxy_primary_group_id,
348353
)?;
349-
openshell_supervisor_process::netns::install_sidecar_bypass_rules(network_proxy_uid)
354+
openshell_supervisor_process::netns::install_sidecar_bypass_rules(proxy_user_id)
350355
}
351356

352357
#[cfg(not(target_os = "linux"))]

0 commit comments

Comments
 (0)