Skip to content

fix(supervisor-network): warn on unsupported L7 access presets#2030

Closed
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:fix/2008-unsupported-l7-access-warning/deepujain
Closed

fix(supervisor-network): warn on unsupported L7 access presets#2030
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:fix/2008-unsupported-l7-access-warning/deepujain

Conversation

@deepujain

Copy link
Copy Markdown

Summary

  • warn when an L7 endpoint uses an unsupported access preset without explicit rules
  • keep startup non-blocking for unsupported REST-style presets while making the ignored policy visible
  • add regression coverage for an unsupported access: allow preset

Closes #2008

Testing

  • cargo fmt --check
  • cargo test -p openshell-supervisor-network validate_unsupported_access_preset_warns
  • cargo test -p openshell-supervisor-network
  • cargo clippy -p openshell-supervisor-network --all-targets -- -D warnings
  • mise run pre-commit

Notes

Opened as draft from a fork so it can be moved to ready-for-review after the contributor vouch step if required.

Signed-off-by: dejain <deepujain@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @deepujain.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot closed this Jun 27, 2026
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@deepujain

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

@deepujain

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: warn when unsupported L7 access presets are ignored

1 participant