fix(supervisor-network): warn on unsupported L7 access presets#2030
Closed
deepujain wants to merge 1 commit into
Closed
fix(supervisor-network): warn on unsupported L7 access presets#2030deepujain wants to merge 1 commit into
deepujain wants to merge 1 commit into
Conversation
Signed-off-by: dejain <deepujain@gmail.com>
|
Thank you for your interest in contributing to OpenShell, @deepujain. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accesspreset without explicit rulesaccess: allowpresetCloses #2008
Testing
cargo fmt --checkcargo test -p openshell-supervisor-network validate_unsupported_access_preset_warnscargo test -p openshell-supervisor-networkcargo clippy -p openshell-supervisor-network --all-targets -- -D warningsmise run pre-commitNotes
Opened as draft from a fork so it can be moved to ready-for-review after the contributor vouch step if required.