fix(core): pin supervisor image tag to gateway version for all drivers#2070
fix(core): pin supervisor image tag to gateway version for all drivers#2070benoitf wants to merge 2 commits into
Conversation
|
/ok to test cb62ca9 |
|
Label |
0582804 to
aa8af37
Compare
|
/ok to test aa8af37 |
|
Minor test concern: Please update the test to verify the stable contract instead (the expected repository plus a non-empty tag), and consider adding an explicit resolver case documenting that assert_eq!(
resolve_supervisor_image_tag(Some("latest"), None, "1.2.3"),
"latest",
);This is a non-blocking test robustness issue rather than a runtime defect. |
aa8af37 to
fd09c75
Compare
|
@TaylorMutch PR amended |
|
/ok to test fd09c75 |
The Podman and Kubernetes drivers defaulted the supervisor image to `:latest` via DEFAULT_SUPERVISOR_IMAGE, while the Docker driver already resolved a version-pinned tag. Extract the tag resolution logic into openshell-core so all three drivers use the same OPENSHELL_IMAGE_TAG > IMAGE_TAG > CARGO_PKG_VERSION priority chain. Closes NVIDIA#2068 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
… API Remove the Docker driver's wrapper functions and call openshell_core::config::default_supervisor_image() directly. Simplify resolve_supervisor_image_tag to accept &[&str] instead of three separate parameters. Signed-off-by: Florent Benoit <fbenoit@nvidia.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com>
fd09c75 to
ac66187
Compare
|
@elezar PR updated with your suggested changes |
Summary
Extract the Docker driver's compile-time supervisor image tag resolution into
openshell-coreso all three compute drivers (Docker, Podman, Kubernetes) pin the supervisor image to the gateway version instead of defaulting to:latest.Related Issue
Closes #2068
Changes
resolve_supervisor_image_tag()anddefault_supervisor_image()toopenshell-core::configwith the same priority chain the Docker driver already used:OPENSHELL_IMAGE_TAG>IMAGE_TAG>CARGO_PKG_VERSION(falls back todevfor0.0.0)DEFAULT_SUPERVISOR_IMAGE_REPOconstant (repo without tag) toopenshell-coreDEFAULT_SUPERVISOR_IMAGE(the:latestconstant)default_supervisor_image()in config default and make the CLI--supervisor-imagearg optional with version-pinned fallbackdefault_supervisor_image()in config default and CLI fallback:latestto use the dynamic defaultTesting
mise run pre-commitpassesChecklist