Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Skip context parallelism tests if not enough GPUs #1508

Merged
merged 3 commits into from
Feb 26, 2025
Merged

[PyTorch] Skip context parallelism tests if not enough GPUs #1508

merged 3 commits into from
Feb 26, 2025
+15 −4

Conversation

timmoon10
Copy link
Collaborator

Description

Some tests in test_fused_attn_with_cp.py require 4 GPUs and they fail on nodes with 2 GPUs. This PR only runs tests if there are enough available GPUs.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring
  • Testing

Changes

  • Skip context parallelism tests if not enough GPUs

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added bug Something isn't working testing Improvements to tests or testing infrastructure 2.1.0 labels Feb 25, 2025
@timmoon10 timmoon10 requested a review from cyanguwa February 25, 2025 22:05
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch L1

@timmoon10 timmoon10 requested a review from cyanguwa February 26, 2025 01:48
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch L1

cyanguwa
cyanguwa approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@cyanguwa cyanguwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmoon10 timmoon10 merged commit 2834e4a into NVIDIA:main Feb 26, 2025
11 of 12 checks passed
timmoon10 added a commit that referenced this pull request Feb 26, 2025
@timmoon10
[PyTorch] Skip context parallelism tests if not enough GPUs (#1508)
867ab06 
* Skip context parallelism tests if not enough GPUs

Signed-off-by: Tim Moon <[email protected]>

* Apply suggestions from code review

Signed-off-by: Tim Moon <[email protected]>

---------

Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyanguwa cyanguwa cyanguwa approved these changes

Assignees
No one assigned
Labels
2.1.0 bug Something isn't working testing Improvements to tests or testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmoon10 @cyanguwa