Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Fix typo #1495

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[PyTorch] Fix typo #1495

merged 2 commits into from
Feb 19, 2025

Conversation

timmoon10
Copy link
Collaborator

Description

Fix a silly typo in FP8 all-gather function.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Fix typo

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10
Fix typo
0c9c1fa 
Signed-off-by: Tim Moon <[email protected]>
@timmoon10 timmoon10 added bug Something isn't working 2.1.0 labels Feb 19, 2025
ksivaman
ksivaman approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, an unfortunate typo since input is a built-in function. This use case is a potential enhancement to linters to flag this as a warning.

@ksivaman ksivaman merged commit 56c0c07 into NVIDIA:main Feb 19, 2025
11 checks passed
timmoon10 added a commit that referenced this pull request Feb 21, 2025
@timmoon10 @ksivaman
[PyTorch] Fix typo (#1495)
9c5436f 
Fix typo

Signed-off-by: Tim Moon <[email protected]>
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksivaman ksivaman ksivaman approved these changes

Assignees
No one assigned
Labels
2.1.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmoon10 @ksivaman