Skip to content

Commit 9b26ae2

Browse files
committed
remove extraneous warnings on incomplete frame finalization
1 parent eff9c1a commit 9b26ae2

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

devices/rtx/frame/Frame.cu

+3-18
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ Frame::~Frame()
6262

6363
bool Frame::isValid() const
6464
{
65-
return m_valid;
65+
return m_renderer && m_renderer->isValid() && m_camera
66+
&& m_camera->isValid() && m_world && m_world->isValid();
6667
}
6768

6869
DeviceGlobalState *Frame::deviceState() const
@@ -93,23 +94,7 @@ void Frame::commitParameters()
9394

9495
void Frame::finalize()
9596
{
96-
if (!m_renderer) {
97-
reportMessage(ANARI_SEVERITY_WARNING,
98-
"missing required parameter 'renderer' on frame");
99-
}
100-
if (!m_camera) {
101-
reportMessage(
102-
ANARI_SEVERITY_WARNING, "missing required parameter 'camera' on frame");
103-
}
104-
if (!m_world) {
105-
reportMessage(
106-
ANARI_SEVERITY_WARNING, "missing required parameter 'world' on frame");
107-
}
108-
109-
m_valid = m_renderer && m_renderer->isValid() && m_camera
110-
&& m_camera->isValid() && m_world && m_world->isValid();
111-
112-
if (!m_valid)
97+
if (!isValid())
11398
return;
11499

115100
auto &hd = data();

devices/rtx/frame/Frame.h

-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ struct Frame : public helium::BaseFrame, public DeviceObject<FrameGPUData>
8989

9090
//// Data ////
9191

92-
bool m_valid{false};
9392
float m_invFrameID{1.f};
9493
int m_perPixelBytes{1};
9594
bool m_denoise{false};

0 commit comments

Comments
 (0)