DesignSpecification:OutdoorAir:SpaceList does not work with Controller:MechanicalVentilation

[mjwitte]

Issue overview

DesignSpecification:OutdoorAir:SpaceList with Controller:MechanicalVentilation results in zero requested OA flow rate in v24.2. In v25.1 it causes a crash, because it's calling Schedule::getCurrentVal with a null pointer.

• The basic problem is that Controller:MechanicalVentilation is set up to copy values from the DesignSpecification:OutdoorAir object(s) into the VentilationMechanical struct to do certain OA component calcs. This doesn't work for DesignSpecification:OutdoorAir:SpaceList. It needs a whole new approach to evaluate the OA requirements by calling OARequirementsData::calcOAFlowRate or similar function(s).
• Perhaps the whole DSOA:SpaceList approach needs to be revisited.
• And this is another use-case not covered by testing.
• @amirroth Would it be acceptable (possible?) to initialize schedule pointers to Sched::GetScheduleAlwaysOn(state) in the declaration? Not that it would fix the zero OA issue here . . .

Operating System (Multiple choices)

Any

Operating System Version

any

Version of EnergyPlus

25.1

Unmethours link or helpdesk ticket number

Helpdesk 16870

Defect file

EnergyPlusDevSupport/DefectFiles

[jmarrec]

@mjwitte does that affect all files or a specific sub use case? I have this PR to OpenStudio that we're considering for the release at the end of the month

• Fix #4219 - Fix #4628 - DesignSpecificationOutdoorAir (use a DSOA:SpaceList if appropriate insead of using first dsoa found) and ControllerMechanicalVentilation upgrades OpenStudio#5384

[mjwitte]

@mjwitte does that affect all files or a specific sub use case? I have this PR to OpenStudio that we're considering for the release at the end of the month

• Fix #4219 - Fix #4628 - DesignSpecificationOutdoorAir (use a DSOA:SpaceList if appropriate insead of using first dsoa found) and ControllerMechanicalVentilation upgrades OpenStudio#5384

@jmarrec I haven't tested other variants, but I think any DSOA:SpaceList will fail in Controller:MechanicalVentilation.

[jmarrec]

I have created an OpenStudio-resources tests which is essentially a MCVE (1k lines versus 13k for the user-provided file) and that exhibits the crash. Adding it to EnergyPlusDevSupport

I have two equivalent files:

• One that references a Single DSOA
• One that references a DSOA:SPaceList which crashes

[jmarrec]

LLDB backtrace

Process 766219 stopped
* thread #1, name = 'energyplus', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x4c)
    frame #0: 0x00007ffff26b9656 libenergyplusapi.so.25.1.0`EnergyPlus::Sched::Schedule::getCurrentVal(this=0x0000000000000000) const at ScheduleManager.hh:275:20
   272 	
   273 	        Real64 getCurrentVal() const
   274 	        {
-> 275 	            return EMSActuatedOn ? EMSVal : currentVal;
   276 	        }
   277 	
   278 	        // Looks up a given Schedule value for an hour & timestep, minding whether DST is enabled or not
(lldb) bt
error: libenergyplusapi.so.25.1.0 0x0f845415: DW_TAG_member '_M_local_buf' refers to type 0x000000000f94006f which extends beyond the bounds of 0x0f84540b
* thread #1, name = 'energyplus', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x4c)
  * frame #0: 0x00007ffff26b9656 libenergyplusapi.so.25.1.0`EnergyPlus::Sched::Schedule::getCurrentVal(this=0x0000000000000000) const at ScheduleManager.hh:275:20
    frame #1: 0x00007ffff3dbd339 libenergyplusapi.so.25.1.0`EnergyPlus::MixedAir::InitOAController(state=0x00007fffffffa7e0, OAControllerNum=1, FirstHVACIteration=true, AirLoopNum=1) at MixedAir.cc:3126:89
    frame #2: 0x00007ffff3da6748 libenergyplusapi.so.25.1.0`EnergyPlus::MixedAir::SimOAController(state=0x00007fffffffa7e0, CtrlName="CONTROLLER OUTDOOR AIR 1", CtrlIndex=0x0000555555cc05d0, FirstHVACIteration=true, AirLoopNum=1) at MixedAir.cc:837:21
    frame #3: 0x00007ffff3da3017 libenergyplusapi.so.25.1.0`EnergyPlus::MixedAir::SimOutsideAirSys(state=0x00007fffffffa7e0, OASysNum=1, FirstHVACIteration=true, AirLoopNum=1) at MixedAir.cc:355:24
    frame #4: 0x00007ffff3da2920 libenergyplusapi.so.25.1.0`EnergyPlus::MixedAir::ManageOutsideAirSystem(state=0x00007fffffffa7e0, OASysName="AIR LOOP HVAC OUTDOOR AIR SYSTEM 1", FirstHVACIteration=true, AirLoopNum=1, OASysNum=0x00005555565fc644) at MixedAir.cc:272:21
    frame #5: 0x00007ffff4109971 libenergyplusapi.so.25.1.0`EnergyPlus::SimAirServingZones::SimAirLoopComponent(state=0x00007fffffffa7e0, CompName="AIR LOOP HVAC OUTDOOR AIR SYSTEM 1", CompType_Num=OAMixer_Num, FirstHVACIteration=true, AirLoopNum=1, CompIndex=0x00005555565fc644, CompPointer=0x0000000000000000, airLoopNum=1, branchNum=1, compNum=1) at SimAirServingZones.cc:3437:31
    frame #6: 0x00007ffff41097ac libenergyplusapi.so.25.1.0`EnergyPlus::SimAirServingZones::SimAirLoopComponents(state=0x00007fffffffa7e0, AirLoopNum=1, FirstHVACIteration=true) at SimAirServingZones.cc:3360:32
    frame #7: 0x00007ffff4107021 libenergyplusapi.so.25.1.0`EnergyPlus::SimAirServingZones::SolveAirLoopControllers(state=0x00007fffffffa7e0, FirstHVACIteration=true, AirLoopNum=1, AirLoopConvergedFlag=0x0000555556984848, IterMax=0x000055555698483c, IterTot=0x0000555556984840, NumCalls=0x0000555556984844) at SimAirServingZones.cc:2847:83
    frame #8: 0x00007ffff410694b libenergyplusapi.so.25.1.0`EnergyPlus::SimAirServingZones::SimAirLoop(state=0x00007fffffffa7e0, FirstHVACIteration=true, AirLoopNum=1, AirLoopPass=1, AirLoopIterMax=0x00007fffffff933c, AirLoopIterTot=0x00007fffffff9340, AirLoopNumCalls=0x00007fffffff9344) at SimAirServingZones.cc:2699:32
    frame #9: 0x00007ffff4105e7a libenergyplusapi.so.25.1.0`EnergyPlus::SimAirServingZones::SimAirLoops(state=0x00007fffffffa7e0, FirstHVACIteration=true, SimZoneEquipment=0x0000555555645cab) at SimAirServingZones.cc:2504:23
    frame #10: 0x00007ffff40f36f2 libenergyplusapi.so.25.1.0`EnergyPlus::SimAirServingZones::ManageAirLoops(state=0x00007fffffffa7e0, FirstHVACIteration=true, SimAir=0x0000555555645ca8, SimZoneEquipment=0x0000555555645cab) at SimAirServingZones.cc:174:20
    frame #11: 0x00007ffff398381d libenergyplusapi.so.25.1.0`EnergyPlus::HVACManager::SimSelectedEquipment(state=0x00007fffffffa7e0, SimAirLoops=0x0000555555645ca8, SimZoneEquipment=0x0000555555645cab, SimNonZoneEquipment=0x0000555555645cac, SimPlantLoops=0x0000555555645caa, SimElecCircuits=0x0000555555645ca9, FirstHVACIteration=0x00007fffffff95a5, LockPlantFlows=false) at HVACManager.cc:1786:43
    frame #12: 0x00007ffff397bf3a libenergyplusapi.so.25.1.0`EnergyPlus::HVACManager::SimHVAC(state=0x00007fffffffa7e0) at HVACManager.cc:826:25
    frame #13: 0x00007ffff3977767 libenergyplusapi.so.25.1.0`EnergyPlus::HVACManager::ManageHVAC(state=0x00007fffffffa7e0) at HVACManager.cc:272:12
    frame #14: 0x00007ffff3ac5909 libenergyplusapi.so.25.1.0`EnergyPlus::HeatBalanceAirManager::CalcHeatBalanceAir(state=0x00007fffffffa7e0) at HeatBalanceAirManager.cc:4491:32
    frame #15: 0x00007ffff3a9d5f7 libenergyplusapi.so.25.1.0`EnergyPlus::HeatBalanceAirManager::ManageAirHeatBalance(state=0x00007fffffffa7e0) at HeatBalanceAirManager.cc:158:23
    frame #16: 0x00007ffff3b76ef7 libenergyplusapi.so.25.1.0`EnergyPlus::HeatBalanceSurfaceManager::ManageSurfaceHeatBalance(state=0x00007fffffffa7e0) at HeatBalanceSurfaceManager.cc:171:48
    frame #17: 0x00007ffff3b041c7 libenergyplusapi.so.25.1.0`EnergyPlus::HeatBalanceManager::ManageHeatBalance(state=0x00007fffffffa7e0) at HeatBalanceManager.cc:206:33
    frame #18: 0x00007ffff2d58f17 libenergyplusapi.so.25.1.0`EnergyPlus::SimulationManager::SetupSimulation(state=0x00007fffffffa7e0, ErrorsFound=0x00007fffffffa533) at SimulationManager.cc:1903:30
    frame #19: 0x00007ffff2d4a0df libenergyplusapi.so.25.1.0`EnergyPlus::SimulationManager::ManageSimulation(state=0x00007fffffffa7e0) at SimulationManager.cc:270:24
    frame #20: 0x00007ffff2441b54 libenergyplusapi.so.25.1.0`RunEnergyPlus(state=0x00007fffffffa7e0, filepath="") at EnergyPlusPgm.cc:421:56
    frame #21: 0x00007ffff2440b7a libenergyplusapi.so.25.1.0`EnergyPlusPgm(args=size=6, filepath="") at EnergyPlusPgm.cc:242:25
    frame #22: 0x0000555555580bf6 energyplus`main(argc=6, argv=0x00007fffffffbf08) at main.cc:60:25
    frame #23: 0x00007ffff102a1ca libc.so.6`__libc_start_call_main(main=(energyplus`main at main.cc:54:1), argc=6, argv=0x00007fffffffbf08) at libc_start_call_main.h:58:16
    frame #24: 0x00007ffff102a28b libc.so.6`__libc_start_main_impl(main=(energyplus`main at main.cc:54:1), argc=6, argv=0x00007fffffffbf08, init=<unavailable>, fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffffffbef8) at libc-start.c:360:3
    frame #25: 0x0000555555580a45 energyplus`_start + 37


(lldb) f 1
frame #1: 0x00007ffff3dbd339 libenergyplusapi.so.25.1.0`EnergyPlus::MixedAir::InitOAController(state=0x00007fffffffa7e0, OAControllerNum=1, FirstHVACIteration=true, AirLoopNum=1) at MixedAir.cc:3126:89
   3123	                        OAFlowMethod == OAFlowCalcMethod::Max) {
   3124	                        TotalPeopleOAFlow += state.dataHeatBal->ZoneIntGain(ZoneNum).NOFOCC * state.dataHeatBal->Zone(ZoneNum).Multiplier *
   3125	                                             state.dataHeatBal->Zone(ZoneNum).ListMultiplier * thisVentMechZone.ZoneOAPeopleRate *
-> 3126	                                             thisVentMechZone.zoneOASched->getCurrentVal();
   3127	                    }
   3128	                }
   3129	                vent_mech.TotPeopleOAFlow = TotalPeopleOAFlow;

(lldb) p thisVentMechZone
(EnergyPlus::MixedAir::VentilationMechanicalZoneProps &) 0x0000555556877050: {
  name = "ZONE WITH 5 SPACES"
  zoneNum = 1
  ZoneOAAreaRate = 0
  ZoneOAPeopleRate = 0
  ZoneOAFlowRate = 0
  ZoneOAACHRate = 0
  ZoneDesignSpecOAObjIndex = 2
  ZoneDesignSpecOAObjName = "ZONE WITH 5 SPACES DSOA SPACE LIST"
  ZoneADEffCooling = 1
  ZoneADEffHeating = 1
  zoneADEffSched = nullptr
  ZoneDesignSpecADObjIndex = 0
  ZoneDesignSpecADObjName = ""
  ZoneSecondaryRecirculation = 0
  ZoneOAFlowMethod = PerPerson
  zoneOASched = nullptr
  oaPropCtlMinRateSched = nullptr
  peopleIndexes = {
    std::__debug::vector<int, std::allocator<int> > = size=0 {}
    m_allocated = false
  }
}
(lldb) p thisVentMechZone.zoneOASched
(EnergyPlus::Sched::Schedule *) nullptr