Skip to content

Improve the behavior when metric queries change #7

Open
@ctberthiaume

Description

@ctberthiaume

When the metric queries change, all the configured metrics are 'not found', so it requires re-mapping the query to each trace.

Rather than saving the explicit name, maybe we should save the reference and index? For example A.value|time|index

Original Issue Report:

This issue concerns X, Y, and Z names but for brevity I'll just mention X.

The runtime error "Unable to find X:" is thrown when an "ALIAS BY" pattern is specified in an InfluxDB query for the X (first) series. It looks like this is because in onDataReceived the name of the X data set is cached in this.panel.pconfig.mapping the first time a query runs. When the "ALIAS BY" query clause is changed and the query runs again the name of the X data settings doesn't get updated because this.panel.pconfig.mapping.X is already set.

I'm not sure what the name caching is for, but having the dmapping.x value always overwrite the mapping.x value seems to work without any obvious side effects.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions