Merge pull request #556 from NativeScript/plamen5kov/fix_interface_ctor_cache

fixed jsobject cache for interface creation

Author: Plamen5kov

runtime/src/main/jni/MetadataNode.cpp

@@ -922,7 +922,7 @@ void MetadataNode::InterfaceConstructorCallback(const v8::FunctionCallbackInfo<v
 		}
 
 		auto className = node->m_implType;
-		SetInstanceMetadata(isolate, implementationObject, node);
+		SetInstanceMetadata(isolate, thiz, node);
 
 		//@@@ Refactor
 		thiz->SetInternalField(static_cast<int>(ObjectManager::MetadataNodeKeys::CallSuper), True(isolate));

test-app/app/src/main/assets/app/tests/testMethodResolution.js

@@ -52,4 +52,30 @@ describe("Test Method Resolution", function () {
         expect(exceptionCaught).toBe(false);
         expect(d).not.toEqual(null);
     });
+
+    it("Should call correct base method overload", function () {
+
+        var d = new com.tns.tests.DerivedClass();
+        var i1 = new com.tns.tests.InterfaceOne({});
+        var i2 = new com.tns.tests.InterfaceTwo({});
+
+        var res1 = d.overloadMethod(i1)
+        var res2 = d.overloadMethod(i2)
+
+        expect(res1).toBe(1);
+        expect(res2).toBe(2);
+    });
+
+    it("Should call correct method overloads", function () {
+
+        var d = new com.tns.tests.BaseClass();
+        var i1 = new com.tns.tests.InterfaceOne({});
+        var i2 = new com.tns.tests.InterfaceTwo({});
+
+        var res1 = d.overloadMethod(i1)
+        var res2 = d.overloadMethod(i2)
+
+        expect(res1).toBe(1);
+        expect(res2).toBe(2);
+    });
 });

test-app/app/src/main/assets/metadata/treeNodeStream.dat

@@ -2,6 +2,14 @@
 
 public class BaseClass
 {
+	public int overloadMethod(InterfaceOne ione) {
+		return 1;
+	}
+
+	public int overloadMethod(InterfaceTwo itwo) {
+		return 2;
+	}
+
 	public int sum(int x, int y)
 	{
 		return x + y;

test-app/app/src/main/assets/metadata/treeStringsStream.dat

@@ -0,0 +1,8 @@
+package com.tns.tests;
+
+/**
+ * Created by plamen5kov on 9/13/16.
+ */
+public interface InterfaceOne {
+
+}

test-app/app/src/main/assets/metadata/treeValueStream.dat

@@ -0,0 +1,7 @@
+package com.tns.tests;
+
+/**
+ * Created by plamen5kov on 9/13/16.
+ */
+public interface InterfaceTwo {
+}