chore: Move permission request for Android 6+ into the plugin

Author: Veselina Radeva

README.md

@@ -58,27 +58,22 @@ var context = imagepicker.create({ mode: "single" }); // use "multiple" for mult
 ### Request permissions, show the images list and process the selection
 
 ``` 
-requestPermissions()
-.then(function() {
-    context
-        .authorize()
-        .then(function() {
-            return context.present();
-        })
-        .then(function(selection) {
-            selection.forEach(function(selected) {
-                // process the selected image
-            });
-            list.items = selection;
-        }).catch(function (e) {
-            // process error
+context
+    .authorize()
+    .then(function() {
+        return context.present();
+    })
+    .then(function(selection) {
+        selection.forEach(function(selected) {
+            // process the selected image
         });
-}).catch(function (e) {
-    // process error
-});
+        list.items = selection;
+    }).catch(function (e) {
+        // process error
+    });
 ```
 
-`requestPermissions` is used to request Android specific permissions which is required for Android 6+ (API 23+). We use [nativescript-permissions](https://www.npmjs.com/package/nativescript-permissions) plugin to do so. Review the demo projects for detailed implementation.
+> **NOTE**: To request permissions for Android 6+ (API 23+) we use [nativescript-permissions](https://www.npmjs.com/package/nativescript-permissions).
 
 ## API
 

demo-angular/app/app.component.ts

@@ -1,7 +1,6 @@
 import { Component, ChangeDetectorRef } from "@angular/core";
 import { ListView } from "tns-core-modules/ui/list-view";
 import { isAndroid } from "tns-core-modules/platform";
-import * as permissions from "nativescript-permissions";
 import * as imagepicker from "nativescript-imagepicker";
 
 @Component({
@@ -31,34 +30,24 @@ export class AppComponent {
 
     startSelection(context) {
         let _that = this;
-        this.requestPermissions()
-        .then(function(){
-            context
-            .authorize()
-            .then(() => {
-                _that.items = [];
-                return context.present();
-            })
-            .then((selection) => {
-                console.log("Selection done:");
-                selection.forEach(function (selected) {
-                    console.log("----------------");
-                    console.log("uri: " + selected.uri);
-                    console.log("fileUri: " + selected.fileUri);
-                });
-                _that.items = selection;
-                _that._changeDetectionRef.detectChanges();
-            }).catch(function (e) {
-                console.log(e);
+        
+        context
+        .authorize()
+        .then(() => {
+            _that.items = [];
+            return context.present();
+        })
+        .then((selection) => {
+            console.log("Selection done:");
+            selection.forEach(function (selected) {
+                console.log("----------------");
+                console.log("uri: " + selected.uri);
+                console.log("fileUri: " + selected.fileUri);
             });
+            _that.items = selection;
+            _that._changeDetectionRef.detectChanges();
+        }).catch(function (e) {
+            console.log(e);
         });
     }
-
-    requestPermissions() {
-        if (isAndroid && (<any>android).os.Build.VERSION.SDK_INT >= 23) {
-            return permissions.requestPermission([(<any>android).Manifest.permission.READ_EXTERNAL_STORAGE]);
-        } else {
-            return Promise.resolve();
-        }
-    }
 }

demo-angular/package.json

@@ -19,7 +19,6 @@
     "@angular/router": "~4.1.0",
     "nativescript-angular": "~3.1.0",
     "nativescript-imagepicker": "../src",
-    "nativescript-permissions": "~1.2.3",
     "nativescript-theme-core": "^1.0.4",
     "nativescript-unit-test-runner": "^0.3.4",
     "reflect-metadata": "~0.1.8",

demo-angular/references.d.ts

@@ -2,7 +2,6 @@ import { EventData } from 'tns-core-modules/data/observable';
 import { Page } from 'tns-core-modules/ui/page';
 import { isAndroid } from "tns-core-modules/platform";
 import * as imagepicker from "nativescript-imagepicker";
-import * as permissions from "nativescript-permissions";
 
 let list;
 
@@ -22,33 +21,20 @@ export function onSelectSingleTap(args) {
 }
 
 function startSelection(context) {
-    requestPermissions()
+    context
+        .authorize()
         .then(function() {
-            context
-                .authorize()
-                .then(function() {
-                    list.items = [];
-                    return context.present();
-                })
-                .then(function(selection) {
-                    console.log("Selection done:");
-                    selection.forEach(function(selected) {
-                        console.log("----------------");
-                        console.log("uri: " + selected.uri);
-                    });
-                    list.items = selection;
-                }).catch(function (e) {
-                    console.log(e);
-                });
+            list.items = [];
+            return context.present();
+        })
+        .then(function(selection) {
+            console.log("Selection done:");
+            selection.forEach(function(selected) {
+                console.log("----------------");
+                console.log("uri: " + selected.uri);
+            });
+            list.items = selection;
         }).catch(function (e) {
             console.log(e);
         });
-}
-
-function requestPermissions() {
-    if (isAndroid && (<any>android).os.Build.VERSION.SDK_INT >= 23) {
-        return permissions.requestPermission([(<any>android).Manifest.permission.READ_EXTERNAL_STORAGE]);
-    } else {
-        return Promise.resolve();
-    }
-}
+}

demo/app/main-page.ts

@@ -10,7 +10,6 @@
   },
   "dependencies": {
     "nativescript-imagepicker": "../src",
-    "nativescript-permissions": "~1.2.3",
     "nativescript-theme-core": "^1.0.4",
     "nativescript-unit-test-runner": "^0.3.4",
     "tns-core-modules": "^3.1.0"
@@ -53,4 +52,4 @@
     "build-android-bundle": "npm run ns-bundle --android --build-app",
     "build-ios-bundle": "npm run ns-bundle --ios --build-app"
   }
-}
+}

demo/package.json

@@ -3,6 +3,7 @@ import * as imagesource from "tns-core-modules/image-source";
 import * as application from "tns-core-modules/application";
 import * as platform from "tns-core-modules/platform";
 import * as imageAssetModule from "tns-core-modules/image-asset";
+import * as permissions from "nativescript-permissions";
 
 interface ArrayBufferStatic extends ArrayBufferConstructor {
     from(buffer: java.nio.ByteBuffer): ArrayBuffer;
@@ -317,7 +318,11 @@ export class ImagePicker {
     }
 
     authorize(): Promise<void> {
-        return Promise.resolve();
+        if ((<any>android).os.Build.VERSION.SDK_INT >= 23) {
+            return permissions.requestPermission([(<any>android).Manifest.permission.READ_EXTERNAL_STORAGE]);
+        } else {
+            return Promise.resolve();
+        }
     }
 
     present(): Promise<SelectedAsset[]> {

demo/references.d.ts

@@ -93,13 +93,6 @@ interface Options {
     * Set the text for the albums button in iOS
     */
     albumsText?: string;
-
-    android?: {
-        /**
-         * Provide a reason for permission request to access external storage on api levels above 23.
-         */
-        read_external_storage?: string;
-    };
 }
 
 export function create(options?: Options): ImagePicker;

src/imagepicker.android.ts

@@ -50,7 +50,8 @@
         "tslint": "~5.4.3"
     },
     "dependencies": {
-        "nativescript-telerik-ui": "^3.0.0"
+        "nativescript-telerik-ui": "^3.0.0",
+        "nativescript-permissions": "~1.2.3"
     },
     "bootstrapper": "nativescript-plugin-seed"
 }