Skip to content

@naverpay/stylelint-config major update #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 21, 2025
Merged

Conversation

yceffort-naver
Copy link
Contributor

@yceffort-naver yceffort-naver commented May 20, 2025

Changes

  • Updated Stylelint dependency to the latest 16.x version. Important: Ensure your project explicitly uses version 16.x.

Key Changes:

  • Stylelint now runs as a native ES module.
    • Change your configuration files to use the .mjs extension, or add "type": "module" to your package.json.
  • Refactored all internal code to use native ES modules.
  • Starting from version 15.x, rules handled by Prettier have been completely removed. (See migration guide)
    • After upgrading, ensure all files processed by Stylelint are also checked by Prettier.
  • All Stylelint-related dependencies have been upgraded.
  • Adjusted peerDependencies and dependencies.

@yceffort-naver yceffort-naver self-assigned this May 20, 2025
@yceffort-naver yceffort-naver requested a review from a team as a code owner May 20, 2025 05:51
@npayfebot
Copy link
Contributor

npayfebot commented May 20, 2025

✅ Changeset detected

Latest commit: 8ee4915

@naverpay/stylelint-config package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@naverpay/stylelint-config 💥 Major
powered by: naverpay changeset detect-add actions

@yceffort-naver
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link
Contributor

Published Canary Packages

@yceffort-naver
Copy link
Contributor Author

@yujeong-jeon

Could you test this canary version in the affiliate-card-web repository? 🤔

@yceffort-naver
Copy link
Contributor Author

verified: yceffort/blog#677

@yceffort-naver yceffort-naver requested a review from mingoos May 20, 2025 06:39
@yceffort-naver
Copy link
Contributor Author

/rc-publish

@npayfebot
Copy link
Contributor

Published Canary Packages

Copy link
Contributor

@keemhyunseok keemhyunseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@yceffort-naver yceffort-naver merged commit a008346 into main May 21, 2025
3 checks passed
@yceffort-naver yceffort-naver deleted the chore/add-changeset branch May 21, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants