Skip to content

Commit c5961eb

Browse files
support/doxygen: add missing doxygen tags to various functions and classes
1 parent 72c630d commit c5961eb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+217
-164
lines changed

bin/decomp/Decompress.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class Decompress : public POSIXApplication
5757
/**
5858
* Decompress the given file
5959
*
60-
* @param file Path to the file to decompress
60+
* @param inputFilename Path to the file to decompress
6161
*
6262
* @return Result code
6363
*/

kernel/API/PrivExec.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include "PrivExec.h"
2222

2323
API::Result PrivExecHandler(const PrivOperation op,
24-
const Address addr)
24+
const Address param)
2525
{
2626
DEBUG("");
2727

@@ -43,7 +43,7 @@ API::Result PrivExecHandler(const PrivOperation op,
4343

4444
case WriteConsole:
4545
assert(Log::instance() != ZERO);
46-
(*Log::instance()) << (char *)addr;
46+
(*Log::instance()) << (char *) param;
4747
return API::Success;
4848

4949
case Panic:

kernel/API/PrivExec.h

+10-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_PRIVEXEC_H
19-
#define __API_PRIVEXEC_H
18+
#ifndef __KERNEL_API_PRIVEXEC_H
19+
#define __KERNEL_API_PRIVEXEC_H
2020

2121
/**
2222
* @addtogroup kernel
@@ -45,6 +45,7 @@ PrivOperation;
4545
* Prototype for user applications. Performs various privileged operations.
4646
*
4747
* @param op The operation to perform.
48+
* @param param Optional parameter value for the given operation
4849
*
4950
* @return API::Success on success and other API::ErrorCode on failure.
5051
*/
@@ -66,7 +67,12 @@ inline API::Result PrivExec(const PrivOperation op,
6667
*/
6768

6869
/**
69-
* Prototype for kernel handler.
70+
* Prototype for kernel handler. Performs various privileged operations.
71+
*
72+
* @param op The operation to perform.
73+
* @param param Optional parameter value for the given operation
74+
*
75+
* @return API::Success on success and other API::ErrorCode on failure.
7076
*/
7177
extern API::Result PrivExecHandler(const PrivOperation op,
7278
const Address param);
@@ -81,4 +87,4 @@ extern API::Result PrivExecHandler(const PrivOperation op,
8187
* @}
8288
*/
8389

84-
#endif /* __API_PRIVEXEC_H */
90+
#endif /* __KERNEL_API_PRIVEXEC_H */

kernel/API/ProcessCtl.h

+15-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_PROCESSCTL_H
19-
#define __API_PROCESSCTL_H
18+
#ifndef __KERNEL_API_PROCESSCTL_H
19+
#define __KERNEL_API_PROCESSCTL_H
2020

2121
#include <FreeNOS/Process.h>
2222
#include <Types.h>
@@ -110,7 +110,18 @@ inline API::Result ProcessCtl(const ProcessID proc,
110110
*/
111111

112112
/**
113-
* Kernel handler prototype.
113+
* Kernel handler prototype. Process management related operations.
114+
*
115+
* @param proc Target Process' ID.
116+
* @param op The operation to perform.
117+
* @param addr Input argument address, used for program entry point for Spawn,
118+
* ProcessInfo pointer for Info.
119+
* @param output Output argument address (optional).
120+
*
121+
* @return API::Success on success and other API::ErrorCode on failure.
122+
* For WaitPID, the process exit status is stored in the upper 16-bits
123+
* of this return value on success. For Spawn, the new PID is stored in
124+
* the upper 16-bits.
114125
*/
115126
extern API::Result ProcessCtlHandler(const ProcessID proc,
116127
const ProcessOperation op,
@@ -127,4 +138,4 @@ extern API::Result ProcessCtlHandler(const ProcessID proc,
127138
* @}
128139
*/
129140

130-
#endif /* __API_PROCESSCTL_H */
141+
#endif /* __KERNEL_API_PROCESSCTL_H */

kernel/API/ProcessID.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_PROCESSID_H
19-
#define __API_PROCESSID_H
18+
#ifndef __KERNEL_API_PROCESSID_H
19+
#define __KERNEL_API_PROCESSID_H
2020

2121
/**
2222
* @addtogroup kernel
@@ -46,4 +46,4 @@
4646
* @}
4747
*/
4848

49-
#endif /* __API_PROCESSID_H */
49+
#endif /* __KERNEL_API_PROCESSID_H */

kernel/API/SystemInfo.h

+8-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_SYSTEMINFO_H
19-
#define __API_SYSTEMINFO_H
18+
#ifndef __KERNEL_API_SYSTEMINFO_H
19+
#define __KERNEL_API_SYSTEMINFO_H
2020

2121
#include <Types.h>
2222

@@ -54,7 +54,11 @@ inline API::Result SystemInfo(SystemInformation *info)
5454
*/
5555

5656
/**
57-
* Kernel prototype.
57+
* Kernel prototype. Retrieves system information.
58+
*
59+
* @param info Pointer to SystemInformation output buffer.
60+
*
61+
* @return API::Success on success and other API::ErrorCode on failure.
5862
*/
5963
extern API::Result SystemInfoHandler(SystemInformation *info);
6064

@@ -119,4 +123,4 @@ SystemInformation;
119123
* @}
120124
*/
121125

122-
#endif /* __API_SYSTEMINFO_H */
126+
#endif /* __KERNEL_API_SYSTEMINFO_H */

kernel/API/VMCopy.h

+13-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_VMCOPY_H
19-
#define __API_VMCOPY_H
18+
#ifndef __KERNEL_API_VMCOPY_H
19+
#define __KERNEL_API_VMCOPY_H
2020

2121
#include <Types.h>
2222

@@ -60,6 +60,16 @@ inline API::Result VMCopy(const ProcessID proc,
6060
*/
6161

6262
/**
63+
* Kernel handler prototype. Copies virtual memory between two processes.
64+
*
65+
* @param proc Remote process.
66+
* @param how Read or Write.
67+
* @param ours Virtual address of the buffer of this process.
68+
* @param theirs Virtual address of the remote process' buffer.
69+
* @param sz Amount of memory to copy.
70+
*
71+
* @return API::Success on success and any other value on error.
72+
*
6373
* @bug VMCopyHandler assumes the theirs parameter points to memory mapped as a small page (PAGESIZE, 4KiB)
6474
* When that memory is actually a large mapping (for example 1MiB on ARM), the internal pageOff variable will be zero.
6575
*/
@@ -79,4 +89,4 @@ extern API::Result VMCopyHandler(const ProcessID proc,
7989
* @}
8090
*/
8191

82-
#endif /* __API_VMCOPY_H */
92+
#endif /* __KERNEL_API_VMCOPY_H */

kernel/API/VMCtl.h

+12-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_VMCTL_H
19-
#define __API_VMCTL_H
18+
#ifndef __KERNEL_API_VMCTL_H
19+
#define __KERNEL_API_VMCTL_H
2020

2121
#include <Types.h>
2222
#include <Memory.h>
@@ -76,6 +76,15 @@ inline API::Result VMCtl(const ProcessID procID,
7676
* @{
7777
*/
7878

79+
/**
80+
* Kernel handler prototype. Examines and modifies virtual memory pages.
81+
*
82+
* @param procID Remote process.
83+
* @param op Determines which operation to perform.
84+
* @param range Describes the memory pages to operate on.
85+
*
86+
* @return API::Success on success and other API::ErrorCode on failure.
87+
*/
7988
extern API::Result VMCtlHandler(const ProcessID procID,
8089
const MemoryOperation op,
8190
Memory::Range *range);
@@ -90,4 +99,4 @@ extern API::Result VMCtlHandler(const ProcessID procID,
9099
* @}
91100
*/
92101

93-
#endif /* __API_VMCTL_H */
102+
#endif /* __KERNEL_API_VMCTL_H */

kernel/API/VMShare.h

+14-6
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __API_VMSHARE_H
19-
#define __API_VMSHARE_H
18+
#ifndef __KERNEL_API_VMSHARE_H
19+
#define __KERNEL_API_VMSHARE_H
2020

2121
#include <FreeNOS/ProcessShares.h>
2222
#include <Types.h>
@@ -32,10 +32,9 @@
3232
/**
3333
* Prototype for user applications. Creates and removes shared virtual memory mappings.
3434
*
35-
* @param op Determines which operation to perform.
3635
* @param pid Remote process.
37-
* @param parameter Parameter for the operation.
38-
* @param size Size parameter for the operation.
36+
* @param op Determines which operation to perform.
37+
* @param share Pointer to the MemoryShare to use in the operation
3938
*
4039
* @return API::Success on success and other API::ErrorCode on failure.
4140
*/
@@ -57,6 +56,15 @@ inline API::Result VMShare(const ProcessID pid,
5756
* @{
5857
*/
5958

59+
/**
60+
* Kernel handler prototype. Creates and removes shared virtual memory mappings.
61+
*
62+
* @param pid Remote process.
63+
* @param op Determines which operation to perform.
64+
* @param share Pointer to the MemoryShare to use in the operation
65+
*
66+
* @return API::Success on success and other API::ErrorCode on failure.
67+
*/
6068
extern API::Result VMShareHandler(const ProcessID pid,
6169
const API::Operation op,
6270
ProcessShares::MemoryShare *share);
@@ -71,4 +79,4 @@ extern API::Result VMShareHandler(const ProcessID pid,
7179
* @}
7280
*/
7381

74-
#endif /* __API_VMSHARE_H */
82+
#endif /* __KERNEL_API_VMSHARE_H */

kernel/Process.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ class Process
7979
* @param id Process Identifier
8080
* @param entry Initial program counter value.
8181
* @param privileged If true, the process has unlimited access to hardware.
82+
* @param map Memory map to use
8283
*/
8384
Process(ProcessID id, Address entry, bool privileged, const MemoryMap &map);
8485

@@ -142,7 +143,7 @@ class Process
142143
/**
143144
* Compare two processes.
144145
*
145-
* @param p Process to compare with.
146+
* @param proc Process to compare with.
146147
*
147148
* @return True if equal, false otherwise.
148149
*/

kernel/arm/ARMProcess.h

+4-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1616
*/
1717

18-
#ifndef __ARM_ARMPROCESS_H
19-
#define __ARM_ARMPROCESS_H
18+
#ifndef __KERNEL_ARM_ARMPROCESS_H
19+
#define __KERNEL_ARM_ARMPROCESS_H
2020

2121
#include <FreeNOS/Process.h>
2222

@@ -41,6 +41,7 @@ class ARMProcess : public Process
4141
* @param id Process Identifier
4242
* @param entry Initial program counter value.
4343
* @param privileged If true, the process has unlimited access to hardware.
44+
* @param map Memory mapping to use to create the process.
4445
*/
4546
ARMProcess(ProcessID id, Address entry, bool privileged, const MemoryMap &map);
4647

@@ -109,4 +110,4 @@ namespace Arch
109110
* @}
110111
*/
111112

112-
#endif /* __ARM_ARMPROCESS_H */
113+
#endif /* __KERNEL_ARM_ARMPROCESS_H */

lib/liballoc/Allocator.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ class Allocator
105105
/**
106106
* Set parent allocator.
107107
*
108-
* @param p New parent allocator.
108+
* @param parent New parent allocator.
109109
*/
110110
void setParent(Allocator *parent);
111111

@@ -147,12 +147,12 @@ class Allocator
147147
/**
148148
* Allocate memory.
149149
*
150-
* @param args Contains the requested size and alignment on input.
151-
* On output, contains the actual allocated address.
150+
* @param range Contains the requested size and alignment on input.
151+
* On output, contains the actual allocated address.
152152
*
153153
* @return Result value.
154154
*/
155-
virtual Result allocate(Range & args);
155+
virtual Result allocate(Range & range);
156156

157157
/**
158158
* Release memory.

lib/liballoc/BitAllocator.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class BitAllocator : public Allocator
8484
* @param args Contains the requested size and alignment on input.
8585
* The alignment value must be a multiple of the chunk size.
8686
* On output, contains the actual allocated address.
87-
* @param bit Bit position in the bitmap array to start searching at.
87+
* @param startBit Bit position in the bitmap array to start searching at.
8888
*
8989
* @return Result value.
9090
*/

lib/liballoc/BubbleAllocator.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class BubbleAllocator : public Allocator
6868
*
6969
* Does nothing for BubbleAllocator.
7070
*
71-
* @param address Points to memory previously returned by allocate().
71+
* @param addr Points to memory previously returned by allocate().
7272
*
7373
* @see allocate
7474
*/

lib/liballoc/SplitAllocator.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ class SplitAllocator : public Allocator
7070
/**
7171
* Allocate sparse (non-contiguous) physical memory.
7272
*
73-
* @param args Contains the requested size on input.
74-
* The alignment and address values are unused.
73+
* @param range Contains the requested size on input.
74+
* The alignment and address values are unused.
7575
* @param function Called for each successful allocation of a page.
7676
*
7777
* @return Result value.

lib/libapp/ArgumentParser.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ void ArgumentParser::setName(const char *name)
9292
m_name = name;
9393
}
9494

95-
void ArgumentParser::setDescription(const String & description)
95+
void ArgumentParser::setDescription(const String & desc)
9696
{
97-
m_description = description;
97+
m_description = desc;
9898
}
9999

100100
ArgumentParser::Result ArgumentParser::registerFlag(char id,

lib/libapp/ArgumentParser.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class ArgumentParser
9090
*
9191
* @param desc Program description string.
9292
*/
93-
void setDescription(const String & desciption);
93+
void setDescription(const String & desc);
9494

9595
/**
9696
* Register a flag Argument

0 commit comments

Comments
 (0)