Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's important to you (the user)? #232

Closed
Neriderc opened this issue Oct 6, 2022 · 45 comments
Closed

What's important to you (the user)? #232

Neriderc opened this issue Oct 6, 2022 · 45 comments

Comments

@Neriderc
Copy link
Owner

Neriderc commented Oct 6, 2022

It would be good to hear what features are important to anyone using GVExport, to help prioritise the order that things are added.

Feel free to mention existing issues that you'd like prioritised, or to suggest things that have not yet been mentioned.

Small things or big things are welcome. You can comment on little things that annoy you, options you wish you had, or big features on your wish list.

@Neriderc Neriderc pinned this issue Oct 6, 2022
@schuco
Copy link

schuco commented Oct 6, 2022

@Neriderc you mentioned optional full screen mode in #234 for mobile devices.
This would be my primary wish to be done for Windows devices too.

Further on:

#195 It would be nice to configure colors. So I prefer the arrow for non blood-related descendants to be better distinguished (e.g. red).

#51 Additionally I would would like to set some options in the admin control panel, especially colors. These would be defaults after a reset.

#92 It was my proposal to store the set of starting persons for later reuse (repeat a diagram after update or adding further members of a tree). My workaround was to store the string of XREFS in a commented list. This workaround still works with the new, improved input of starting persons using a dropdown list. You just can open and see the XREF-list by clicking the advanced options. You can even reenter such a string into this field of the advanced options. It is nice that the names of the starting persons are generated and displayed automatically then. So you can easily edit the stored list.
I could further on use my workaround, which can be used much more comfortable now.
A special feature in GVE would have low priority.

@hartenthaler
Copy link

... full-screen mode in #234 for mobile devices. This would be my primary wish to be done for Windows devices too.

Then GVExport will look even a bit more like the custom modules LIN and TAM. Sounds as a good option.

The arrow colours can be modified already, but I would prefer to have the same possibility as user for some other elements, too.

For me saving the selected persons and families in the clippings cart (#177 ) has a high priority. But not enough time. I will try to get it done, nevertheless.

@Neriderc Neriderc moved this to Ready in GVExport Oct 6, 2022
@Neriderc Neriderc added this to GVExport Oct 6, 2022
@Neriderc Neriderc removed this from GVExport Oct 6, 2022
@Neriderc
Copy link
Owner Author

Neriderc commented Oct 6, 2022

Thanks guys, I will aim for #234 and #195 for the next release. I'll be sure to support full screen mode on desktop browsers as well.

I'll look at the control panel settings after this. This is something I'm unfamiliar with, so I will need some time to research how to do this.

I have deliberately left #92 untouched. We have many changes happening and I worry that the saved data will quickly become useless if we change things too much. Hearing it's low priority, I will continue to hold off on this and will revisit at a later point.

@schuco

#195 It would be nice to configure colors. So I prefer the arrow for non blood-related descendants to be better distinguished (e.g. red).

As @hartenthaler mentioned, this is available right now. It's in the appearance section, at the bottom of the advanced settings.

If you click to enable different arrows based on blood relationship, two new options appear. Click the colour and you will be presented with a colour picker to change the colour. This is using your browser's built in colour picker, so it will look different in different browsers, but you should be able to change the colour using this.

image

@hartenthaler
Copy link

I'll look at the control panel settings after this. This is something I'm unfamiliar with, so I will need some time to research how to do this.

Not very complex. You can have a look at my module "Extended Family". You need a view file to be presented in the control panel with all the options, like https://github.com/hartenthaler/hh_extended_family/blob/main/resources/views/settings.phtml

And two functions:

@Neriderc
Copy link
Owner Author

Neriderc commented Oct 7, 2022

@hartenthaler Thanks! I will take a look after I'm done with the first two items.

@schuco
Copy link

schuco commented Oct 7, 2022

Getting proposed changes done so fast I dare to propose another one:

If you stepwise build up a tree it is sometimes complicated to find the starting person in a big diagram as GraphViz reorders the tree-picture in every step.
Could there be an option to highlight the starting person(s)?
This would also be helpful if you want to explain a GVE-diagram to someone by pointing out special persons.

@schuco
Copy link

schuco commented Oct 7, 2022

Before I leave for a journey one further comment on probably important improvements.
This is not important for me, but may be very important for installations without GraphViz .

I could not test creating SVG or PNG files with browser rendering so it may already now be possible to produce PDF directly. In case that this is not so, direct output in PDF would be desirable.
In my experience the optimal output for diagrams is in PDF. This has very small size compared to PNG or JPG and it can be scaled much better in a browser. Also a normal user like me can't handle SVG and will not send it to even less experienced family members.
Therefore producing PDF-output in installations without GraphViz seems to be important.

@Neriderc
Copy link
Owner Author

Neriderc commented Oct 7, 2022

If you stepwise build up a tree it is sometimes complicated to find the starting person in a big diagram as GraphViz reorders the tree-picture in every step. Could there be an option to highlight the starting person(s)? This would also be helpful if you want to explain a GVE-diagram to someone by pointing out special persons.

Yes, I agree this would be great! How do you imagine this looking? Maybe something like having a different background colour for the the starting person(s)? Making them larger? Something else? Ideally this would be easy to find even on a really big diagram - probably changing the background colour of the individual would be the easiest way to achieve this. But I'm happy to hear suggestions.

In my experience the optimal output for diagrams is in PDF. This has very small size compared to PNG or JPG and it can be scaled much better in a browser. Also a normal user like me can't handle SVG and will not send it to even less experienced family members.

SVG should open fine in any modern browser, but I agree, it's not the format I'd choose if sending the file to someone else. We have PDF export covered in #24 but it hasn't been looked at in any detail (it is already supported if you have GraphViz installed on the server). I had a cursory look a while back and it didn't look as simple as the other file types. I'll have a proper look at it after looking at #51 which I'm looking at now.

@schuco
Copy link

schuco commented Oct 7, 2022

Changing background color!

@Neriderc
Copy link
Owner Author

Neriderc commented Oct 7, 2022

Sounds good! I have created #240 to do this. It's reasonably straightforward to do, I'll finish what I'm working on then make this change.

@Neriderc
Copy link
Owner Author

Just so it's clear, I intend to leave this here for a while, anyone can reply and say what's important to them, or suggest their new ideas here if they don't want to create a new issue.

@Neriderc Neriderc changed the title What's important to you? What's important to you (the user)? Oct 22, 2022
@schuco
Copy link

schuco commented Dec 16, 2022

Lots of new options and possibilities in GVE fire the imagination for further application scenarios.
I could not sleep well last night and had the following idea. One could let the family history unfold with successive GVE diagrams as in time-lapse: starting with the earliest ancestor and progressing in selectable time periods, the living individuals and completed families (marriages) in the respective time period could be highlighted in the diagram as can be done for starting persons.
The resulting diagrams could be either downloaded one after the other or shown one after the other in the browser (possibly superimposed).
A problem certainly will be missing dates for birth, death and marriage especially in early periods. There it could help to obtain the data from the clipboard, where missing information could be temporarily replaced with plausible assumptions. Also an extended clipboard menu could be used for the options and input parameters.

@hartenthaler
Copy link

Have you seen the huhwt-wtlin module and it's Timeline function?

@schuco
Copy link

schuco commented Dec 20, 2022

I have tried it by selecting my ancestors with their families and displayed them on the LIN timeline.
I still have problems with the rather abstract description of LIN and TAM I have found. Is there a description with the interpretation of what you see by an example?

@hartenthaler
Copy link

The documentation for TAM and LIN is not finalized. And the modules are really complex.

There are several screenshots available in the documentation. Maybe you can select one. Then I (or the author of this module) can try to explain it in more detail. Or take a screenshot of your data and then open an issue at the GitHub LIN site.

@schuco
Copy link

schuco commented Dec 21, 2022

@hartenthaler thank you, I will come back to you after my broken laptop will be repaired

@schuco
Copy link

schuco commented Jun 18, 2023

I have been using v 2.1.18.1 for a while now and appreciate its versatility and added useful tools.
So I used saved settings to update notes on family branches by having one saved setting (downloaded) for each diagram in the notes. Updating is quite easy now and automatically inludes the latest state of the database..
I had a problem storing my be too many saved settings and will report this in a seperate item. The same for a slight problem setting resolution options for jpeg-files.
Here are some proposals or wishes for further improvements or new features:

  1. Option to rename saved settings.
  2. There is the nice feature to search individuals in a diagram and center the display around these. Could there be the option to mark this individual with a certain colour like what can be done for starting individuals? Often I have to set an individual to be a starting individual only to get it marked.
  3. I come back to an issue I have repeatedly put forward: The reaction on the click on an individual in the diagram.
  • you can choose the treatment of starting individuals in the advanced options (default, add to list, ...) . I personally would prefere to see this option field in the primary menu, as I want to know which reaction can be expected and also to be able to switch this setting easily
  • maybe these options can be even extended by an option, where a click does not result in going to the individuals page but rather in adding this individual to the list of starting persons without leaving GVExport.

@Neriderc
Copy link
Owner Author

1. Option to rename saved settings.

At the moment you can click to load the settings, then change the name and save it again. Then delete the previous one.

Adding the functionality to rename the setting makes sense though, and shouldn't be difficult. I have added #442

2. There is the nice feature to search individuals in a diagram and center the display around these. Could there be the option to mark this individual with a certain colour like what can be done for starting individuals? Often I  have to set an individual to be a starting individual only to get it marked.

I will have a think about how to do this. I am thinking perhaps have an advanced setting that has a list of XREFs to highlight. To make this more user friendly, we could have either the ability to search a person to add to the list (like in the starting individual's list), or we could have the ability to click a person in the diagram and add them to this list (or both). Any thoughts?

3. I come back to an issue I have repeatedly put forward: The reaction on the click on an individual in the diagram.

It's on the list! #402

I have replied here so that the thoughts are not forgotten!

@aXymmetrx
Copy link

Hi @Neriderc, I've been using webtrees with GVExport v2.1.18.2 and I can't thank you enough for your effort on supporting it.

I've only been using all of this stuff only for one week and it seems working as intended.

Until I hit a family with multiple marriage. For my case, a husband with 2 wifes. It seems that in GVExport (with 'Combined' Diagram type), it will create 2 sets of node for the husband paired for each wife.

[Husband + 1st Wife + its Descendants] and [Husband + 2nd Wife + its Descendants] (marked purple and green in image respectively)

With a lot of individuals and families were added into the list, the visual produced seems odd for this family as it puts the [Husband + 1st Wife + its Descendants] and [Husband + 2nd Wife + its Descendants] really far away from each other. Which I think to compensate for the 'lines' for connecting the nodes. Here's the example:

1

I tried exporting the GEDCOM file from webtrees and open it on yEd. It turns out yEd visual out a straight connecting lines, and the husband node were only created once with 2 wifes are put closer/next to each his wifes. Here's the example:

2

3

So I wondering if GVExport can have such option? A straight connecting lines with no duplicate nodes when comes to multiple relationship? It looks doable on different software, so I'm guessing that it should possibly can work on GVExport too.

I may sound pedantic on this, but showing this graph to elderly people carries a lot of emotions for them. Having them to see their multiple partners were put farther away surely hits differently on them. Having me to explain to them that 'thats how the software tries to efficiently sort and fit the people in once place' is beyond my imagination for them to understand.

Sorry for the long post. I hope I can get your comment on this. I'm not really understand how does this stuff works. I hope you can spare me off.

Anyway thanks!

@Neriderc
Copy link
Owner Author

I've created a new issue to track this, @aXymmetrx did you want to take a look? #455

@WeT-Klb
Copy link

WeT-Klb commented Nov 25, 2023

If you choose 3 or 4 generations, would it be possible not to reduce the size of the graphic?
It would be nicer if the individual persons were displayed in the same size, but the graphic could be moved accordingly - as in "MyHeritage".
GVExport with 2 Generations
GVExport with 3 Generations
GVExport with 4 Generations

@Neriderc
Copy link
Owner Author

@WeT-Klb so your preference would be that the view would be up close like in your fist image, even if your diagram was large?

I don't want to promise anything before I've tried, but I don't see why it couldn't be done this way. It would just be a bit of maths to calculate the right zoom level, which seems doable. If you could confirm that is what you want (up close) then we can create a new issue (feel free to do this if you'd like) and I can start working on it.

@WeT-Klb
Copy link

WeT-Klb commented Nov 26, 2023

Exactly. My personal opinion is that the view as in "MyHeritage" would be optimal. For example, you can select a person and then navigate through the whole tree by moving the graphic. Have you ever seen that there?
In my personal opinion, that would be the icing on the cake.

MyHeritage look

@marwelin
Copy link

It would be nice to have a marriage date prefix like ∞ in the diagram.

@marwelin
Copy link

The name abbreviation "First given name and surname" would be great for complete but compact diagrams.

@Neriderc
Copy link
Owner Author

Thanks for the suggestions! I've created a couple of "issues" to track them. They should be pretty straightforward, so I'll aim to put them in the next release.

@marwelin
Copy link

Thank you for adding the "issues" 😄
I just had some additional ideas for a complete but compact view...

@marwelin
Copy link

To shorten the width of the diagram, all dates (Birth, Death, Marriage) may get the additional option "compact date", which uses only the first three characters of the month.
For example: 12. Nov. 2024 instead of 12. November 2024

@marwelin
Copy link

The birth and death locations stand behind the date, but the marriage location has an extra row.
Is there a reason for that behaviour or may the marriage location stand behind the marriage date.
For example:
20. Mar. 2024 (Anywhere)
instead of
20. Mar. 2024
(Anywhere)

@marwelin
Copy link

The arrow-line between person frames does not begin direct at the start-frame, but its arrow ends direct at the target-frame.
May the arrow-line start direct at the start-frame?
The reason for that is: I had situations, where it looked like, that the arrow-line started in another horizontal arrow-line.

@Neriderc
Copy link
Owner Author

To shorten the width of the diagram, all dates (Birth, Death, Marriage) may get the additional option "compact date", which uses only the first three characters of the month. For example: 12. Nov. 2024 instead of 12. November 2024

I'll add this one as another issue. It should be simple enough to do.

The birth and death locations stand behind the date, but the marriage location has an extra row. Is there a reason for that behaviour or may the marriage location stand behind the marriage date. For example: 20. Mar. 2024 (Anywhere) instead of 20. Mar. 2024 (Anywhere)

Which diagram type are you using? With the Separated type, having the location at the end stretches out the oval:
screen shot of family tree showing oval representing marriage is very wide
Compared to underneath:
similar to above but marriage location is under marriage date, now the oval is taller and less enlongated

I think combined mode would look better side by side though, is that what you're meaning? Maybe we could change it to be side by side only for combined mode?

The arrow-line between person frames does not begin direct at the start-frame, but its arrow ends direct at the target-frame. May the arrow-line start direct at the start-frame? The reason for that is: I had situations, where it looked like, that the arrow-line started in another horizontal arrow-line.

I don't know that we get much say in this. The diagram is assembled using Graphviz (hence the name GVExport), and it has been tricky in the past to make small tweaks like this. I've never seen it far enough away that I could get confused over who it referred to. What settings are you using for diagram? In particular, separated or combined, and top-to-bottom or left-to-right?

@marwelin
Copy link

marwelin commented Mar 20, 2024

I use the combined-type and top-to-bottom.
Yes, you are right, the separated-type looks better with 2-line "date \n (location)"
and the combined type looks better with side-by-side "date (location)".

@marwelin
Copy link

The arrow-line between person frames does not begin direct at the start-frame, but its arrow ends direct at the target-frame.
May the arrow-line start direct at the start-frame?
The reason for that is: I had situations, where it looked like, that the arrow-line started in another horizontal arrow-line.

I just can't reproduce the situation.
Maybe the situation was eliminated by reordering some children order in webtrees yesterday.

@Neriderc
Copy link
Owner Author

Ok great, I'll plan for these in the next release, and further discussion can happen on the individual issues.

@marwelin
Copy link

marwelin commented Mar 21, 2024

What do you think about this idea:
If a couple is married, but nothing else is known about marriage, the marriage prefix ∞ could be shown in the diagram even without date+place.
This would allow to distinguish a married couple from a not married couple in the diagram.

grafik

@Neriderc
Copy link
Owner Author

I believe that's how it's implemented!

If you want to try out the changes before an official release, you can download the main branch. Basically go to the "code" page on github, click the bright green "code" button, and download the zip file. Install as usual, making sure you remove any dots in the folder name as webtrees will ignore extensions with a dot in the folder name.

@marwelin
Copy link

I am trying out the main branch now. As there is no extra issue for the last proposal, I answer here.
Thank you. It works exactly as I imagined.

Nevertheless here is an additional thought regarding this issue:
There are so many symbols for couple relationships. Here they are

  • ∞ (or oo) for marriage
  • I∞ for 1st marriage
  • II∞ for 2nd marriage
  • o for engaged
  • o|o for divorced
  • o-o for relationship (not married, illegitimate or common law union)

I think we do not need most of them in the diagram, except of ∞ for marriage.
What I am not sure about is the o|o symbol for divorced.
Is divorced important enough to be shown in the diagram? (maybe enable/disable configurable)

@hartenthaler
Copy link

For me it would be the most important:

  • no symbol = not married
  • marriage symbol = married and no divorce known
  • divorce symbol = married and divorced

@marwelin
Copy link

marwelin commented Mar 22, 2024

I can agree with the first two

  • no symbol = not married
  • marriage symbol = married and no divorce known

I do not agree to the third, combining the divorce symbol to married and divorced information.
This is because, the marriage date and place is often known and more interesting.
The divorce event is often known, but not the date and place.

If a couple is married, the married symbol +date +place should always be shown.
And if the couple is divorced, the divorce symbol +date +place should be shown additionally to the married information.

@hartenthaler
Copy link

hartenthaler commented Mar 22, 2024

What should happen if a couple marries, gets divorced, and marries again? You can enter such a case in two families or in one family. If there are two families this is shown already correctly in GVExport with two boxes as shown in the diagram (Niarchos was married two times to Eugenia Livanos (and additionaly to her sister)).
gvexport (10)

If it is entered in one family, GVExport shows only the first marriage. I would expect that GVExport shows all events in the family, ie the first marriage event, the divorce event and the second marriage event.

@marwelin
Copy link

marwelin commented Mar 22, 2024

From my opinion it is wrong to enter this in one family, even if webtrees/GEDCOM allows to do this.
Let's have a look on the timelime, having real life in mind

  1. couple marries = family1
  2. couple divorces = family1 no longer exists
  3. couple marries again = family2
    At this point of time there is no reason to reactivate family1.
    From my point of view family1 would be a wrong/inconsistent GEDCOM coding.
    In your real-life family-register-book there will also be a new family entry and not a reactivation of the first marriage.

@hartenthaler
Copy link

There were already intensive discussions about 1 or 2 families in the past. There are advantages and disadvantages for both. I agree with you @marwelin to prefer 2 families, but both options are possible in webtrees and in GEDCOM. The disadvantage of 2 families is: if there are children born during the first marriage and other children born during the second marriage they are now called step-brother/sister and not brother/sister which feels more natural.

@marwelin
Copy link

@hartenthaler The described disadvantage of 2 families of the same couple can be solved in webtrees.
webtrees knows from the INDI tags, that the persons of the FAM tags are equal. In that case webtrees should be able to distinguish right between brother/sister and step-brother/sister.

@hartenthaler
Copy link

GVExport is a great and very flexible tool! I just used it to show how a small, but complex family can be shown. See https://discourse.genealogy.net/t/ungewoehnliche-stammbaeume-visualisieren/822464/23

@Neriderc
Copy link
Owner Author

Neriderc commented Jun 1, 2024

I think everything in this post has been addressed, but it's getting long so I thought I'd create a fresh new one. If something isn't already captured in an open issue, please post it in the new issue here and I'll close this one.

@Neriderc Neriderc closed this as completed Jun 1, 2024
@Neriderc Neriderc unpinned this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants