Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with display of preferred name (pre-release bug) #465

Closed
Neriderc opened this issue Feb 28, 2024 · 2 comments · Fixed by #468
Closed

Issue with display of preferred name (pre-release bug) #465

Neriderc opened this issue Feb 28, 2024 · 2 comments · Fixed by #468
Labels
pre-release bug Issue with pre-release version of GVExport
Milestone

Comments

@Neriderc
Copy link
Owner

          Using the merged code I see a problem similarly reported already in December testing d3-graphviz:

grafik
This behaviour is observed when long text is to be displayed in a box and a nickname (underscored text) is followed by normal text.
Official release works as expected:
grafik

Originally posted by @schuco in #268 (comment)

@Neriderc Neriderc added the pre-release bug Issue with pre-release version of GVExport label Feb 28, 2024
@Neriderc Neriderc added this to the 2.1.20 milestone Feb 28, 2024
@Neriderc Neriderc linked a pull request Mar 19, 2024 that will close this issue
@Neriderc
Copy link
Owner Author

@schuco I have made a change that should fix this for you.

The root cause seems to be when the browser isn't picking up the right font. I've made some changes which should fix it for the default Arial font (which should be ok everywhere, I've tested Windows, Linux, and Android on Firefox. Interestingly, Chrome has a lot less issues, maybe they grab the font from the google server if it doesn't exist).

Unfortunately you may still find some fonts have an issue. We aren't able to tell which fonts are available, so can't hide the ones that will fail and cause an issue, but it does seem to be a lot better for me now.

Let me know if you're still having issues.

@schuco
Copy link

schuco commented Mar 19, 2024

grafik

I am happy with that! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-release bug Issue with pre-release version of GVExport
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants