fix: Source route table checking issue (#23)

Author: Nerivec

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "zigbee-on-host",
-    "version": "0.1.6",
+    "version": "0.1.7",
     "description": "ZigBee stack designed to run on a host and communicate with a radio co-processor (RCP)",
     "engines": {
         "node": ">=20.17.0"

package.json

@@ -4270,22 +4270,23 @@ export class OTRCPDriver extends EventEmitter<AdapterDriverEventMap> {
         }
 
         for (const existingEntry of existingEntries) {
-            if (newEntry.pathCost !== existingEntry.pathCost) {
-                return false;
-            }
+            if (newEntry.pathCost === existingEntry.pathCost && newEntry.relayAddresses.length === existingEntry.relayAddresses.length) {
+                let matching = true;
 
-            if (newEntry.relayAddresses.length !== existingEntry.relayAddresses.length) {
-                return false;
-            }
+                for (let i = 0; i < newEntry.relayAddresses.length; i++) {
+                    if (newEntry.relayAddresses[i] !== existingEntry.relayAddresses[i]) {
+                        matching = false;
+                        break;
+                    }
+                }
 
-            for (const relay of newEntry.relayAddresses) {
-                if (!existingEntry.relayAddresses.includes(relay)) {
-                    return false;
+                if (matching) {
+                    return true;
                 }
             }
         }
 
-        return true;
+        return false;
     }
 
     /**

src/drivers/ot-rcp-driver.ts

@@ -1365,14 +1365,23 @@ describe("OT RCP Driver", () => {
         });
 
         it("checks if source route exists in entries for a given device", () => {
-            driver.sourceRouteTable.set(0x4b8e, [{ relayAddresses: [1, 2], pathCost: 3 }]);
+            driver.sourceRouteTable.set(0x4b8e, [
+                { relayAddresses: [1, 2], pathCost: 3 },
+                { relayAddresses: [11, 22], pathCost: 3 },
+                { relayAddresses: [33, 22, 44], pathCost: 4 },
+                { relayAddresses: [], pathCost: 1 },
+            ]);
             const existingEntries = driver.sourceRouteTable.get(0x4b8e)!;
 
+            expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [], pathCost: 1 }, existingEntries)).toStrictEqual(true);
+            expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [], pathCost: 2 }, existingEntries)).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [1, 2], pathCost: 3 }, existingEntries)).toStrictEqual(true);
+            expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [2, 1], pathCost: 3 }, existingEntries)).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [1, 2], pathCost: 2 }, existingEntries)).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [3], pathCost: 2 }, existingEntries)).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [4, 5], pathCost: 3 }, existingEntries)).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [1, 2], pathCost: 3 })).toStrictEqual(true);
+            expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [2, 1], pathCost: 3 })).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [1, 2], pathCost: 2 })).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [3], pathCost: 2 })).toStrictEqual(false);
             expect(driver.hasSourceRoute(0x4b8e, { relayAddresses: [4, 5], pathCost: 3 })).toStrictEqual(false);