Skip to content

Commit b9f4513

Browse files
committed
Added protein/peptide level FDR checkbox. Bumped to v2.6
1 parent 72587bb commit b9f4513

File tree

5 files changed

+80
-20
lines changed

5 files changed

+80
-20
lines changed

MSFragger-GUI/src/umich/msfragger/Version.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*/
2424
public class Version {
2525
public static final String PROP_VER = "msfragger.gui.version";
26-
public static final String VERSION = "2.5";
26+
public static final String VERSION = "2.6";
2727

2828
public static String getVersion() {
2929
java.util.ResourceBundle bundle = java.util.ResourceBundle.getBundle("umich/msfragger/gui/Bundle"); // NOI18N

MSFragger-GUI/src/umich/msfragger/gui/Bundle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# To change this license header, choose License Headers in Project Properties.
22
# To change this template file, choose Tools | Templates
33
# and open the template in the editor.
4-
msfragger.gui.version=2.5
4+
msfragger.gui.version=2.6
55
default.msfragger.jar=MSFragger.jar
66
default.msconvert.win=msconvert.exe
77
default.msconvert.nix=msconvert

MSFragger-GUI/src/umich/msfragger/gui/MsfraggerGuiFrame.form

+32-9
Original file line numberDiff line numberDiff line change
@@ -1043,7 +1043,7 @@
10431043
</Group>
10441044
<EmptySpace max="-2" attributes="0"/>
10451045
<Component id="jPanel1" min="-2" max="-2" attributes="0"/>
1046-
<EmptySpace pref="436" max="32767" attributes="0"/>
1046+
<EmptySpace pref="415" max="32767" attributes="0"/>
10471047
</Group>
10481048
</Group>
10491049
</DimensionLayout>
@@ -1061,16 +1061,24 @@
10611061
<Layout>
10621062
<DimensionLayout dim="0">
10631063
<Group type="103" groupAlignment="0" attributes="0">
1064-
<Group type="102" alignment="0" attributes="0">
1064+
<Group type="102" attributes="0">
10651065
<EmptySpace max="-2" attributes="0"/>
1066-
<Group type="103" groupAlignment="1" max="-2" attributes="0">
1067-
<Component id="checkReportFilter" max="32767" attributes="0"/>
1068-
<Component id="checkReportDbAnnotate" max="32767" attributes="0"/>
1069-
</Group>
1070-
<EmptySpace type="unrelated" max="-2" attributes="0"/>
10711066
<Group type="103" groupAlignment="0" attributes="0">
1072-
<Component id="textReportDbAnnotate" pref="461" max="32767" attributes="0"/>
1073-
<Component id="textReportFilter" max="32767" attributes="0"/>
1067+
<Group type="102" alignment="0" attributes="0">
1068+
<Group type="103" groupAlignment="1" max="-2" attributes="0">
1069+
<Component id="checkReportFilter" max="32767" attributes="0"/>
1070+
<Component id="checkReportDbAnnotate" max="32767" attributes="0"/>
1071+
</Group>
1072+
<EmptySpace type="unrelated" max="-2" attributes="0"/>
1073+
<Group type="103" groupAlignment="0" attributes="0">
1074+
<Component id="textReportDbAnnotate" pref="461" max="32767" attributes="0"/>
1075+
<Component id="textReportFilter" max="32767" attributes="0"/>
1076+
</Group>
1077+
</Group>
1078+
<Group type="102" alignment="0" attributes="0">
1079+
<Component id="checkReportProteinLevelFdr" min="-2" max="-2" attributes="0"/>
1080+
<EmptySpace min="0" pref="0" max="32767" attributes="0"/>
1081+
</Group>
10741082
</Group>
10751083
<EmptySpace max="-2" attributes="0"/>
10761084
</Group>
@@ -1089,6 +1097,8 @@
10891097
<Component id="checkReportFilter" alignment="3" min="-2" max="-2" attributes="0"/>
10901098
<Component id="textReportFilter" alignment="3" min="-2" max="-2" attributes="0"/>
10911099
</Group>
1100+
<EmptySpace max="-2" attributes="0"/>
1101+
<Component id="checkReportProteinLevelFdr" min="-2" max="-2" attributes="0"/>
10921102
<EmptySpace max="32767" attributes="0"/>
10931103
</Group>
10941104
</Group>
@@ -1126,6 +1136,19 @@
11261136
<AuxValue name="JavaCodeGenerator_allCodePost" type="java.lang.String" value="loadLastReportFilter();"/>
11271137
</AuxValues>
11281138
</Component>
1139+
<Component class="javax.swing.JCheckBox" name="checkReportProteinLevelFdr">
1140+
<Properties>
1141+
<Property name="selected" type="boolean" value="true"/>
1142+
<Property name="text" type="java.lang.String" value="Report Protein level FDR"/>
1143+
<Property name="toolTipText" type="java.lang.String" value="&lt;html&gt;Which FDR (False Discovery Rate) level to use:&#xa;&lt;ul&gt;&#xa; &lt;li&gt;Checked - Protein level FDR&lt;/li&gt;&#xa; &lt;li&gt;Unchecked - Peptide level FDR&lt;/li&gt;&#xa;&lt;/ul&gt;"/>
1144+
</Properties>
1145+
<Events>
1146+
<EventHandler event="stateChanged" listener="javax.swing.event.ChangeListener" parameters="javax.swing.event.ChangeEvent" handler="checkReportProteinLevelFdrStateChanged"/>
1147+
</Events>
1148+
<AuxValues>
1149+
<AuxValue name="JavaCodeGenerator_allCodePost" type="java.lang.String" value="loadLastReportProteinLevelFdr();"/>
1150+
</AuxValues>
1151+
</Component>
11291152
</SubComponents>
11301153
</Container>
11311154
<Component class="javax.swing.JCheckBox" name="checkCreateReport">

MSFragger-GUI/src/umich/msfragger/gui/MsfraggerGuiFrame.java

+45-9
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ private void initComponents() {
309309
ghostTextPepProph = new GhostText(textReportDbAnnotate, TEXT_SAME_SEQ_DB, defTextColor);
310310
checkReportFilter = new javax.swing.JCheckBox();
311311
textReportFilter = new javax.swing.JTextField();
312+
checkReportProteinLevelFdr = new javax.swing.JCheckBox();
312313
checkCreateReport = new javax.swing.JCheckBox();
313314
btnReportDefaultsClosed = new javax.swing.JButton();
314315
btnReportDefaultsOpen = new javax.swing.JButton();
@@ -963,19 +964,33 @@ public void focusLost(java.awt.event.FocusEvent evt) {
963964
}
964965
});
965966

967+
checkReportProteinLevelFdr.setSelected(true);
968+
checkReportProteinLevelFdr.setText("Report Protein level FDR");
969+
checkReportProteinLevelFdr.setToolTipText("<html>Which FDR (False Discovery Rate) level to use:\n<ul>\n <li>Checked - Protein level FDR</li>\n <li>Unchecked - Peptide level FDR</li>\n</ul>");
970+
checkReportProteinLevelFdr.addChangeListener(new javax.swing.event.ChangeListener() {
971+
public void stateChanged(javax.swing.event.ChangeEvent evt) {
972+
checkReportProteinLevelFdrStateChanged(evt);
973+
}
974+
});
975+
966976
javax.swing.GroupLayout jPanel1Layout = new javax.swing.GroupLayout(jPanel1);
967977
jPanel1.setLayout(jPanel1Layout);
968978
jPanel1Layout.setHorizontalGroup(
969979
jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
970980
.addGroup(jPanel1Layout.createSequentialGroup()
971981
.addContainerGap()
972-
.addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.TRAILING, false)
973-
.addComponent(checkReportFilter, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)
974-
.addComponent(checkReportDbAnnotate, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
975-
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED)
976982
.addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
977-
.addComponent(textReportDbAnnotate, javax.swing.GroupLayout.DEFAULT_SIZE, 461, Short.MAX_VALUE)
978-
.addComponent(textReportFilter))
983+
.addGroup(jPanel1Layout.createSequentialGroup()
984+
.addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.TRAILING, false)
985+
.addComponent(checkReportFilter, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)
986+
.addComponent(checkReportDbAnnotate, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
987+
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED)
988+
.addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
989+
.addComponent(textReportDbAnnotate, javax.swing.GroupLayout.DEFAULT_SIZE, 461, Short.MAX_VALUE)
990+
.addComponent(textReportFilter)))
991+
.addGroup(jPanel1Layout.createSequentialGroup()
992+
.addComponent(checkReportProteinLevelFdr)
993+
.addGap(0, 0, Short.MAX_VALUE)))
979994
.addContainerGap())
980995
);
981996
jPanel1Layout.setVerticalGroup(
@@ -989,10 +1004,13 @@ public void focusLost(java.awt.event.FocusEvent evt) {
9891004
.addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.BASELINE)
9901005
.addComponent(checkReportFilter)
9911006
.addComponent(textReportFilter, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE))
1007+
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
1008+
.addComponent(checkReportProteinLevelFdr)
9921009
.addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
9931010
);
9941011

9951012
loadLastReportFilter();
1013+
loadLastReportProteinLevelFdr();
9961014

9971015
checkCreateReport.setSelected(true);
9981016
checkCreateReport.setText("Create report");
@@ -1039,7 +1057,7 @@ public void actionPerformed(java.awt.event.ActionEvent evt) {
10391057
.addComponent(btnReportDefaultsOpen)))
10401058
.addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
10411059
.addComponent(jPanel1, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)
1042-
.addContainerGap(436, Short.MAX_VALUE))
1060+
.addContainerGap(415, Short.MAX_VALUE))
10431061
);
10441062

10451063
tabPane.addTab("Report", null, panelReport, "");
@@ -2037,6 +2055,11 @@ private void btnReportDefaultsOpenActionPerformed(java.awt.event.ActionEvent evt
20372055
loadDefaultsReportFilter(SearchTypeProp.open);
20382056
}//GEN-LAST:event_btnReportDefaultsOpenActionPerformed
20392057

2058+
private void checkReportProteinLevelFdrStateChanged(javax.swing.event.ChangeEvent evt) {//GEN-FIRST:event_checkReportProteinLevelFdrStateChanged
2059+
boolean selected = checkReportProteinLevelFdr.isSelected();
2060+
ThisAppProps.save(ThisAppProps.PROP_CHECKBOX_REPORT_PROTEIN_LEVEL_FDR, Boolean.toString(selected));
2061+
}//GEN-LAST:event_checkReportProteinLevelFdrStateChanged
2062+
20402063
public void loadLastPeptideProphet() {
20412064
String val = ThisAppProps.load(ThisAppProps.PROP_TEXT_CMD_PEPTIDE_PROPHET);
20422065
if (val != null) {
@@ -2112,6 +2135,16 @@ private String getFraggerLableJavaVer() {
21122135
return sb.toString();
21132136
}
21142137

2138+
private void loadLastReportProteinLevelFdr() {
2139+
String v = ThisAppProps.load(ThisAppProps.PROP_CHECKBOX_REPORT_PROTEIN_LEVEL_FDR);
2140+
if (v == null) {
2141+
checkReportProteinLevelFdr.setSelected(true);
2142+
} else {
2143+
Boolean wasSelected = Boolean.valueOf(v);
2144+
checkReportProteinLevelFdr.setSelected(wasSelected);
2145+
}
2146+
}
2147+
21152148
public enum SearchTypeProp {open, closed}
21162149

21172150
private boolean validateAndSavePhilosopherPath(String path) {
@@ -3155,8 +3188,10 @@ private List<ProcessBuilder> processBuildersReport(String programsDir, String wo
31553188
}
31563189
cmd.add("--pepxml");
31573190
cmd.add(workingDir);
3158-
cmd.add("--protxml");
3159-
cmd.add(combinedProtFilePath.toString());
3191+
if (checkReportProteinLevelFdr.isSelected()) {
3192+
cmd.add("--protxml");
3193+
cmd.add(combinedProtFilePath.toString());
3194+
}
31603195
builders.add(new ProcessBuilder(cmd));
31613196
}
31623197

@@ -3437,6 +3472,7 @@ private String getDefaultBinPhilosopher() {
34373472
private javax.swing.JCheckBox checkDryRun;
34383473
private javax.swing.JCheckBox checkReportDbAnnotate;
34393474
private javax.swing.JCheckBox checkReportFilter;
3475+
private javax.swing.JCheckBox checkReportProteinLevelFdr;
34403476
private javax.swing.JCheckBox chkProteinProphetInteractStar;
34413477
private javax.swing.JCheckBox chkRunPeptideProphet;
34423478
private javax.swing.JCheckBox chkRunProteinProphet;

MSFragger-GUI/src/umich/msfragger/params/ThisAppProps.java

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public class ThisAppProps extends Properties {
4444
public static final String PROP_BIN_PATH_PHILOSOPHER = "path.textfield.peptide-prophet";
4545
public static final String PROP_TEXTFIELD_PATH_PROTEIN_PROPHET = "path.textfield.protein-prophet";
4646
public static final String PROP_TEXTFIELD_REPORT_FILTER = "report.filter";
47+
public static final String PROP_CHECKBOX_REPORT_PROTEIN_LEVEL_FDR = "report.proteinlevelfdr";
4748

4849
public static final String PROP_TEXT_CMD_PEPTIDE_PROPHET = "peptideprophet.cmd.line.opts";
4950
public static final String PROP_TEXT_CMD_PROTEIN_PROPHET = "proteinprophet.cmd.line.opts";

0 commit comments

Comments
 (0)