Use sets for tags/tiering.object_tags and add plan modifiers to use state for unknown

Author: brinnjoyce

internal/provider/storage/storage_volume_data_source.go

@@ -267,7 +267,7 @@ func (d *StorageVolumeDataSource) Schema(ctx context.Context, req datasource.Sch
 						MarkdownDescription: "Determines how many days must pass before inactive data in a volume using the Auto or Snapshot-Only policy is considered cold and eligible for tiering",
 						Computed:            true,
 					},
-					"object_tags": schema.ListAttribute{
+					"object_tags": schema.SetAttribute{
 						ElementType:         types.StringType,
 						MarkdownDescription: "Object tags are applied to objects in tiered storage",
 						Computed:            true,
@@ -356,7 +356,7 @@ func (d *StorageVolumeDataSource) Schema(ctx context.Context, req datasource.Sch
 				MarkdownDescription: "Whether or not snapshot copy locking is enabled on the volume.",
 				Computed:            true,
 			},
-			"tags": schema.ListAttribute{
+			"tags": schema.SetAttribute{
 				ElementType:         types.StringType,
 				MarkdownDescription: "List of tags associated with the volume",
 				Computed:            true,

internal/provider/storage/storage_volume_resource.go

@@ -20,6 +20,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/objectplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/setplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -413,11 +414,14 @@ func (r *StorageVolumeResource) Schema(ctx context.Context, req resource.SchemaR
 							int64planmodifier.UseStateForUnknown(),
 						},
 					},
-					"object_tags": schema.ListAttribute{
+					"object_tags": schema.SetAttribute{
 						ElementType:         types.StringType,
 						MarkdownDescription: "Object tags are applied to objects in tiered storage",
 						Optional:            true,
 						Computed:            true,
+						PlanModifiers: []planmodifier.Set{
+							setplanmodifier.UseStateForUnknown(),
+						},
 					},
 				},
 			},
@@ -576,11 +580,14 @@ func (r *StorageVolumeResource) Schema(ctx context.Context, req resource.SchemaR
 					},
 				},
 			},
-			"tags": schema.ListAttribute{
+			"tags": schema.SetAttribute{
 				ElementType:         types.StringType,
-				MarkdownDescription: "List of tags associated with the volume",
+				MarkdownDescription: "Set of tags associated with the volume",
 				Optional:            true,
 				Computed:            true,
+				PlanModifiers: []planmodifier.Set{
+					setplanmodifier.UseStateForUnknown(),
+				},
 			},
 			"id": schema.StringAttribute{
 				Computed:            true,

internal/provider/storage/storage_volumes_data_source.go

@@ -221,7 +221,7 @@ func (d *StorageVolumesDataSource) Schema(ctx context.Context, req datasource.Sc
 									MarkdownDescription: "Determines how many days must pass before inactive data in a volume using the Auto or Snapshot-Only policy is considered cold and eligible for tiering",
 									Computed:            true,
 								},
-								"object_tags": schema.ListAttribute{
+								"object_tags": schema.SetAttribute{
 									ElementType:         types.StringType,
 									MarkdownDescription: "Object tags are applied to objects in tiered storage",
 									Computed:            true,
@@ -306,9 +306,9 @@ func (d *StorageVolumesDataSource) Schema(ctx context.Context, req datasource.Sc
 							Computed:            true,
 							MarkdownDescription: "Volume identifier",
 						},
-						"tags": schema.ListAttribute{
+						"tags": schema.SetAttribute{
 							ElementType:         types.StringType,
-							MarkdownDescription: "List of tags associated with the volume",
+							MarkdownDescription: "Set of tags associated with the volume",
 							Computed:            true,
 						},
 					},