From fc755cd65e0fe3e6414b206ead8aaad5fd2a728d Mon Sep 17 00:00:00 2001 From: Vishva Rodrigo Date: Wed, 22 May 2019 23:59:05 +0530 Subject: [PATCH 1/3] Standarized the function Since it is non-trivial case, inline if preferred. --- .../niws/loadbalancer/LegacyEurekaClientProvider.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/LegacyEurekaClientProvider.java b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/LegacyEurekaClientProvider.java index 5ccadc19..269e2357 100644 --- a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/LegacyEurekaClientProvider.java +++ b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/LegacyEurekaClientProvider.java @@ -14,10 +14,6 @@ class LegacyEurekaClientProvider implements Provider { @Override public synchronized EurekaClient get() { - if (eurekaClient == null) { - eurekaClient = DiscoveryManager.getInstance().getDiscoveryClient(); - } - - return eurekaClient; + return (eurekaClient == null)?DiscoveryManager.getInstance().getDiscoveryClient():eurekaClient; } -} \ No newline at end of file +} From 7a2488205f7030bb8f6046db03025ef3ed1757e5 Mon Sep 17 00:00:00 2001 From: Vishva Rodrigo Date: Thu, 23 May 2019 08:38:05 +0530 Subject: [PATCH 2/3] Non-trivial case inline if Since it is non-trivial case, preferred to have inline if. --- .../loadbalancer/EurekaNotificationServerListUpdater.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java index 2b388db7..d9bf12c1 100644 --- a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java +++ b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java @@ -83,10 +83,7 @@ public void run() { private int getCorePoolSize() { int propSize = poolSizeProp.get(); - if (propSize > 0) { - return propSize; - } - return 2; // default + return (propSize > 0)?propSize:2 // 2 = default; } } From 856bd5df2cfe3630f1b4ad8039bc6bf67c061b93 Mon Sep 17 00:00:00 2001 From: Vishva Rodrigo Date: Thu, 23 May 2019 08:45:31 +0530 Subject: [PATCH 3/3] Non trivial case patch --- .../niws/loadbalancer/EurekaNotificationServerListUpdater.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java index d9bf12c1..e92affcf 100644 --- a/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java +++ b/ribbon-eureka/src/main/java/com/netflix/niws/loadbalancer/EurekaNotificationServerListUpdater.java @@ -83,7 +83,7 @@ public void run() { private int getCorePoolSize() { int propSize = poolSizeProp.get(); - return (propSize > 0)?propSize:2 // 2 = default; + return (propSize > 0)?propSize:2; // 2 = default } }