Fixed borked cache files on failed web requests

Author: dktapps

compile.sh

@@ -331,7 +331,9 @@ function download_file {
 			echo "Cache hit for URL: $url" >> "$DIR/install.log"
 		else
 			echo "Downloading file to cache: $url" >> "$DIR/install.log"
-			_download_file "$1" > "$DOWNLOAD_CACHE/$cached_filename" 2>> "$DIR/install.log"
+			#download to a tmpfile first, so that we don't leave borked cache entries for later runs
+			_download_file "$1" > "$DOWNLOAD_CACHE/.temp" 2>> "$DIR/install.log"
+			mv "$DOWNLOAD_CACHE/.temp" "$DOWNLOAD_CACHE/$cached_filename" >> "$DIR/install.log" 2>&1
 		fi
 		cat "$DOWNLOAD_CACHE/$cached_filename" 2>> "$DIR/install.log"
 	else

windows-compile-vs.ps1

@@ -227,7 +227,9 @@ function download-file {
         echo "Cache hit for URL: $url" >> $log_file
     } else {
         echo "Downloading file from $url to $cached_path" >> $log_file
-        Invoke-WebRequest -Uri $url -OutFile $cached_path >> $log_file 2>&1
+        #download to a tmpfile first, so that we don't leave borked cache entries for later runs
+        Invoke-WebRequest -Uri $url -OutFile "$download_cache/.temp" >> $log_file 2>&1
+        Move-Item "$download_cache/.temp" $cached_path >> $log_file 2>&1
     }
     if (!(Test-Path $cached_path)) {
         pm-fatal-error "Failed to download file from $url"