Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Class for data loading #86

Open
cversteeg opened this issue Mar 8, 2021 · 2 comments
Open

Abstract Class for data loading #86

cversteeg opened this issue Mar 8, 2021 · 2 comments

Comments

@cversteeg
Copy link

It would be helpful to provide an abstract class that will guide people to fit data into the PyalData format. A few abstract methods with well defined I/O that the user has to implement will make using the toolbox much easier.

Thanks!

@bagibence
Copy link
Collaborator

Thanks for the suggestion! Could you maybe elaborate what that would look like? What are typical problems that might come up? (Please forgive my ignorance, I've never collected data.)

Since the data is just a pandas.DataFrame, all the constructors here should work.

@mattperich @raeedcho could you maybe describe what the Matlab version does?

@raeedcho
Copy link
Contributor

It's a bit hard to describe, but the code for loading things is here (with the main script being convertDataToTD and the meat of the setup in initSignalStruct): https://github.com/mattperich/TrialData/tree/master/DataProcessing

The main idea is to pass in handles to functions that match an input-output spec, along with parameters for those functions. The documentation in there should cover how the system works, at least broadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants