CI Uses bash instead of batch on Azure Windows jobs (scikit-learn#20715)

Co-authored-by: Olivier Grisel <[email protected]>

azure-pipelines.yml

@@ -242,6 +242,7 @@ jobs:
         PYTHON_ARCH: '64'
         PYTEST_VERSION: '*'
         COVERAGE: 'true'
+        DISTRIB: 'conda'
       py37_pip_openblas_32bit:
         PYTHON_VERSION: '3.7'
         PYTHON_ARCH: '32'

build_tools/azure/install_win.sh

@@ -0,0 +1,37 @@
+#!/bin/bash
+
+set -e
+set -x
+
+if [[ "$PYTHON_ARCH" == "64" ]]; then
+    conda create -n $VIRTUALENV -q -y python=$PYTHON_VERSION numpy scipy cython matplotlib wheel pillow joblib
+
+    source activate $VIRTUALENV
+
+    pip install threadpoolctl
+
+    if [[ "$PYTEST_VERSION" == "*" ]]; then
+        pip install pytest
+    else
+        pip install pytest==$PYTEST_VERSION
+    fi
+else
+    pip install numpy scipy cython pytest wheel pillow joblib threadpoolctl
+fi
+
+if [[ "$PYTEST_XDIST_VERSION" != "none" ]]; then
+    pip install pytest-xdist
+fi
+
+if [[ "$COVERAGE" == "true" ]]; then
+    pip install coverage codecov pytest-cov
+fi
+
+python --version
+pip --version
+
+# Build scikit-learn
+python setup.py bdist_wheel
+
+# Install the generated wheel package to test it
+pip install --pre --no-index --find-links dist scikit-learn

build_tools/azure/windows.yml

@@ -18,13 +18,14 @@ jobs:
     SKLEARN_SKIP_NETWORK_TESTS: '1'
     PYTEST_VERSION: '5.2.1'
     PYTEST_XDIST: 'true'
-    TMP_FOLDER: '$(Agent.WorkFolder)\tmp_folder'
+    PYTEST_XDIST_VERSION: 'latest'
+    TEST_DIR: '$(Agent.WorkFolder)/tmp_folder'
   strategy:
     matrix:
       ${{ insert }}: ${{ parameters.matrix }}
 
   steps:
-    - powershell: Write-Host "##vso[task.prependpath]$env:CONDA\Scripts"
+    - bash: echo "##vso[task.prependpath]$CONDA/Scripts"
       displayName: Add conda to PATH for 64 bit Python
       condition: eq(variables['PYTHON_ARCH'], '64')
     - task: UsePythonVersion@0
@@ -34,21 +35,18 @@ jobs:
         architecture: 'x86'
       displayName: Use 32 bit System Python
       condition: eq(variables['PYTHON_ARCH'], '32')
-    - script: |
-        build_tools\\azure\\install.cmd
+    - bash: ./build_tools/azure/install_win.sh
       displayName: 'Install'
-    - script: |
-        build_tools\\azure\\test_script.cmd
+    - bash: ./build_tools/azure/test_script.sh
       displayName: 'Test Library'
-    - script: |
-        build_tools\\azure\\upload_codecov.cmd
+    - bash: ./build_tools/azure/upload_codecov.sh
       condition: and(succeeded(), eq(variables['COVERAGE'], 'true'))
       displayName: 'Upload To Codecov'
       env:
         CODECOV_TOKEN: $(CODECOV_TOKEN)
     - task: PublishTestResults@2
       inputs:
-        testResultsFiles: '$(TMP_FOLDER)\$(JUNITXML)'
+        testResultsFiles: '$(TEST_DIR)/$(JUNITXML)'
         testRunTitle: ${{ format('{0}-$(Agent.JobName)', parameters.name) }}
       displayName: 'Publish Test Results'
       condition: succeededOrFailed()