Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run in Docker #26

Closed
duraki opened this issue Nov 15, 2018 · 5 comments
Closed

Run in Docker #26

duraki opened this issue Nov 15, 2018 · 5 comments
Labels
enhancement good first issue

Comments

@duraki
Copy link

duraki commented Nov 15, 2018

As with many open-source tools, it's encouraged to create Dockerfile, and compose, to run the project in isolated, container environment.
@Nhoya
Copy link
Owner

Nhoya commented Nov 15, 2018

Hi,
I like this idea but I think I'll wait the 1.0.0 release. If you want to contribute anyway feel free to open a PR

Nhoya added a commit that referenced this issue Nov 15, 2018
@Nhoya
Added Dockerfile for develop #26
2c26eee
@Nhoya
Copy link
Owner

Nhoya commented Nov 15, 2018

I pushed a dockerfile for the develop branch if you want to test it I'll be happy to hear your feedback

@duraki
Copy link
Author

duraki commented Nov 15, 2018

Ah, that was fast, we partly solved #25; great. I wrote a few comments on your patch. Testing in progress, will get back at you.

@Nhoya
Copy link
Owner

Nhoya commented Nov 19, 2018

Any news about it?

@duraki
Copy link
Author

duraki commented Nov 19, 2018

Sorry for late delay. Seems that it works fine. Tested under latest MacOS Mojave.

@Nhoya Nhoya closed this as completed Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duraki @Nhoya