Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria roles for glider-dots are not contained by their required parent element #240

Open
IshfaqAhmedProg opened this issue Oct 30, 2022 · 2 comments

Comments

@IshfaqAhmedProg
Copy link

image

Steps to Reproduce:

  1. Create a project and configure it to use glider-js
  2. Enable dots in glider-js config.
  3. Run Lighthouse Analysis on the app

Expected Fix

  1. The .glider-dots parent container should have aria role "tablist" if the aria role for each .glider-dot is "tab".

As stated in https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role

Elements with the role tab must either be a child of an element with the tablist role, or have their id as part of the aria-owns property of a tablist

Possible Fix _.dots.setAttribute('role','tablist') to the function below in glider.js file

image

@jennypns
Copy link

jennypns commented Dec 8, 2022

I think this has been fixed, but nobody commented on your issue. :( In glider.js line 222, I see the attribute set just as you suggested.

glider-js-line-222-role-tablist

@IshfaqAhmedProg
Copy link
Author

yes, it's been fixed! Thanks @kevinfarrugia for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants