Problem
The base.njk template uses class="site-header" and class="site-footer" for the header and footer elements. Standard convention and most CSS frameworks use simply class="header" and class="footer".
Current behavior
<header class="site-header">
<footer class="site-footer">
Expected behavior
<header class="header">
<footer class="footer">
Impact
Sites migrating to the plugin that use .header and .footer selectors in CSS and tests need to change all references to .site-header and .site-footer.
The dart_node site uses .header and .footer throughout its CSS and test suite.
Suggestion
Use class="header" and class="footer" to match standard conventions. The <header> and <footer> HTML5 elements already provide semantic meaning, so the site- prefix is redundant.
Problem
The
base.njktemplate usesclass="site-header"andclass="site-footer"for the header and footer elements. Standard convention and most CSS frameworks use simplyclass="header"andclass="footer".Current behavior
Expected behavior
Impact
Sites migrating to the plugin that use
.headerand.footerselectors in CSS and tests need to change all references to.site-headerand.site-footer.The dart_node site uses
.headerand.footerthroughout its CSS and test suite.Suggestion
Use
class="header"andclass="footer"to match standard conventions. The<header>and<footer>HTML5 elements already provide semantic meaning, so thesite-prefix is redundant.