Skip to content

[RFC] Secondary subs #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dskiba opened this issue Nov 5, 2024 · 0 comments
Open

[RFC] Secondary subs #259

dskiba opened this issue Nov 5, 2024 · 0 comments

Comments

@dskiba
Copy link

dskiba commented Nov 5, 2024

Hello guys, first of all, thank you for creating such a useful product!

I’d like to discuss an additional feature: “secondary subtitles.” Personally, I find it very useful, as it allows me to get both language contexts simultaneously.

Thanks to the great architecture, it’s easy to implement, as I have done in WIP PR

In simple terms, it works like this:

  1. Save the previously selected language subtitles.
  2. If there is a previously selected subtitle, display it at the top of the page.

Bonus point: I think it's going to work for all supported platforms

The code is still a bit messy, but it works for me, though I’ve temporarily removed the draggable feature since I need to adjust the subtitles’ placement.

If you’re open to this feature, we can dive deeper into the details. But first, I’d love to hear the authors’ thoughts on it.

Let me know if you need further refinement!

Pull Request: #258

output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant