Use git_blob_filter instead of git_blob_rawcontent

Author: joshuaspence

src/libfetchers/git-utils.cc

@@ -668,6 +668,7 @@ struct GitSourceAccessor : SourceAccessor
     struct State
     {
         ref<GitRepoImpl> repo;
+        std::string gitRev;
         Object root;
         std::optional<lfs::Fetch> lfsFetch = std::nullopt;
     };
@@ -678,6 +679,7 @@ struct GitSourceAccessor : SourceAccessor
         : state_{
                 State {
                     .repo = repo_,
+                    .gitRev = rev.gitRev(),
                     .root = peelToTreeOrBlob(lookupObject(*repo_, hashToOID(rev)).get()),
                     .lfsFetch = smudgeLfs ? std::make_optional(lfs::Fetch(*repo_, hashToOID(rev))) : std::nullopt,
                 }
@@ -707,7 +709,51 @@ struct GitSourceAccessor : SourceAccessor
             }
         }
 
-        return std::string((const char *) git_blob_rawcontent(blob.get()), git_blob_rawsize(blob.get()));
+        // Apply git filters including CRLF conversion for the final return
+        git_buf filtered = GIT_BUF_INIT;
+        git_blob_filter_options opts = GIT_BLOB_FILTER_OPTIONS_INIT;
+        /*
+        if (git_object_type(state->root.get()) == GIT_OBJECT_COMMIT) {
+            auto commit = peelObject<Commit>(state->root.get(), GIT_OBJECT_COMMIT);
+            opts.attr_commit_id = *git_commit_id(commit.get());
+        }
+        */
+          /*
+          git_oid oid;
+          
+          int error = git_oid_fromstr(&oid, state->repo->getWorkdirRef()->c_str());
+          if (error != 0) {
+              const git_error *e = git_error_last();
+              std::string errorMsg = e ? e->message : "Unknown error";
+              git_buf_dispose(&filtered);
+              throw std::runtime_error("Failed to filter blob: " + errorMsg + " " + state->repo->getWorkdirRef()->c_str());
+
+          }
+          */
+
+        git_oid oid;
+
+        if (git_oid_fromstr(&oid, state->gitRev.c_str()))
+            throw Error("cannot convert '%s' to a Git OID", state->gitRev.c_str());
+
+        opts.attr_commit_id = oid;
+        opts.flags = GIT_BLOB_FILTER_ATTRIBUTES_FROM_COMMIT;
+
+        int error = git_blob_filter(&filtered, blob.get(), path.rel_c_str(), &opts);
+        if (error != 0) {
+            const git_error *e = git_error_last();
+            std::string errorMsg = e ? e->message : "Unknown error";
+            git_buf_dispose(&filtered);
+            throw std::runtime_error("Failed to filter blob: " + errorMsg);
+        }
+        std::string result(filtered.ptr, filtered.size);
+        git_buf_dispose(&filtered);
+
+        if (strcmp(path.c_str(), "/buildconf.bat")) {
+            printInfo("readBlob(%s) ==> %s => %s", path, result.find("\r") != std::string::npos ? "yes" : "no", opts.attr_commit_id);
+        }
+
+        return result;
     }
 
     std::string readFile(const CanonPath & path) override