Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: add sellout as maintainer for their Hackage packages #382412

Closed
wants to merge 1 commit into from

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Feb 15, 2025

I am adding myself as a maintainer for Hackage packages I’ve created. I’ve missed them failing in the past. A few had been broken in Nixpkgs, only one still is now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

I am adding myself as a maintainer for [Hackage packages I’ve
created](https://hackage.haskell.org/user/sellout). I’ve missed them failing in
the past. A few had been broken in Nixpkgs, only one still is now.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 15, 2025
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hackage-packages.nix needs to be edited as well

@sellout
Copy link
Contributor Author

sellout commented Feb 15, 2025

@donovanglover Thanks! Do you know how I’m supposed to regenerate that file?

@sternenseemann
Copy link
Member

sternenseemann commented Feb 15, 2025

I've done that for you and picked the change onto haskell-updates: 6c42718.

I think the process is explicitly only documented here, I'll mention it in the nixpkgs manual as well eventually.

@sellout
Copy link
Contributor Author

sellout commented Feb 15, 2025

@sternenseemann Thanks!

One more question: there are a couple packages of mine that are deprecated on Hackage (e.g., https://hackage.haskell.org/package/yaya-test). Will those automatically be removed from the package set, or should they be added to the “dont-distribute-packages” list?

@sellout sellout deleted the add-sellout-hackage-maintainer branch February 16, 2025 00:01
@maralorn
Copy link
Member

We ignore the deprecated flag. But if CI fails they will automatically be marked broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants