isExecutable check for PHDR placement adjustment isn't reliable

[rcombs]

See

patchelf/src/patchelf.cc

Line 745 in 6066239

if (isExecutable) {

This check is insufficient, as it only handles cases where the file has a PT_INTERP header, which means it won't run on static executables. Most static executables don't need to read AT_PHDR, but some do; e.g. static PIE executables.

This could alternately be handled by enforcing that PHDRs are always in the first page, which would also fix #153.

[rcombs]

Actually, it looks like the #153 is already fixed in 63d0db9, so the impact of removing the isExecutable check altogether should be fairly minor at this point (barring other issues like #164).

[domenkozar]

Since https://nixos.org/releases/patchelf/patchelf-0.10/ is out, this is fixed?

[rcombs]

The issue persists in master. I'll be sending a PR with a few relevant changes shortly.

[ararslan]

Actually, it looks like the #153 is already fixed in 63d0db9

Is it? I opened #153 a year after that commit. 🤔

[domenkozar]

The PR is at #166 but it would be great if someone can reproduce this on master (and ideally attach a binary to this issue and describe how to reproduce).