fix: move bundlephobia call in the backend (#92)

* feat: add new routes and handle error

* fix: pass httpie error to polka

* feat: replace request

* fix: delete forgotten console.log

* revert: port context

Author: tony-go

public/js/utils.js

@@ -214,7 +214,7 @@ export async function getBundlephobiaSize(name, version) {
   try {
     const {
       gzip, size, dependencySizes
-    } = await getJSON(`https://bundlephobia.com/api/size?package=${name}@${version}`);
+    } = await getJSON(`/bundle/${name}/${version}`);
     const fullSize = dependencySizes.reduce((prev, curr) => prev + curr.approximateSize, 0);
 
     document.querySelector(".size-gzip").textContent = prettyBytes(gzip);

src/commands/http.js

@@ -6,8 +6,8 @@ import { buildServer } from "../http-server/index.js";
 
 export async function start(json = "nsecure-result.json", options = {}) {
   const port = Number(options.port);
-
   const dataFilePath = path.join(process.cwd(), json);
+
   const httpServer = buildServer(dataFilePath, {
     port: Number.isNaN(port) ? 0 : port
   });

src/http-server/bundle.js

@@ -0,0 +1,23 @@
+import { get as getRequest } from "@myunisoft/httpie";
+import send from "@polka/send-type";
+
+const kBaseBundlePhobiaUrl = "https://bundlephobia.com/api";
+
+export async function get(req, res) {
+  const { pkgName, version } = req.params;
+
+  const pkgTemplate = version ? `${pkgName}@${version}` : pkgName;
+  try {
+    const { data } = await getRequest(`${kBaseBundlePhobiaUrl}/size?package=${pkgTemplate}`);
+    const { gzip, size, dependencySizes } = data;
+
+    return send(res, 200, {
+      gzip,
+      size,
+      dependencySizes
+    });
+  }
+  catch (error) {
+    return send(res, error.statusCode, { error: error.statusMessage });
+  }
+}

src/http-server/index.js

@@ -13,6 +13,7 @@ import * as i18n from "@nodesecure/i18n";
 import * as root from "./root.js";
 import * as data from "./data.js";
 import * as flags from "./flags.js";
+import * as bundle from "./bundle.js";
 import * as middleware from "./middleware.js";
 
 export function buildServer(dataFilePath, options = {}) {
@@ -29,9 +30,12 @@ export function buildServer(dataFilePath, options = {}) {
   httpServer.get("/data", data.get);
   httpServer.get("/flags", flags.getAll);
   httpServer.get("/flags/description/:title", flags.get);
+  httpServer.get("/bundle/:pkgName", bundle.get);
+  httpServer.get("/bundle/:pkgName/:version", bundle.get);
 
   httpServer.listen(httpConfigPort, () => {
-    const link = `http://localhost:${httpServer.server.address().port}`;
+    const port = httpServer.server.address().port;
+    const link = `http://localhost:${port}`;
     console.log(kleur.magenta().bold(i18n.getToken("cli.http_server_started")), kleur.cyan().bold(link));
 
     if (openLink) {

test/httpServer.spec.js

@@ -86,7 +86,63 @@ test("'/data' should return the fixture payload we expect", async(tape) => {
   tape.end();
 });
 
+test("'/bundle/:name/:version' should return the bundle size", async(tape) => {
+  const result = await get(new URL("/bundle/flatstr/1.0.12", HTTP_URL));
+
+  tape.equal(result.statusCode, 200);
+  tape.equal(result.headers["content-type"], "application/json;charset=utf-8");
+  checkBundleResponse(tape, result.data);
+});
+
+test("'/bundle/:name/:version' should return an error if it fails", async(tape) => {
+  tape.plan(2);
+  const wrongVersion = undefined;
+
+  try {
+    await get(new URL(`/bundle/rimraf/${wrongVersion}`, HTTP_URL));
+  }
+  catch (error) {
+    tape.equal(error.statusCode, 404);
+    tape.equal(error.data.error, "Not Found");
+  }
+
+  tape.end();
+});
+
+test("'/bundle/:name' should return the bundle size of the last version", async(tape) => {
+  const result = await get(new URL("/bundle/flatstr", HTTP_URL));
+
+  tape.equal(result.statusCode, 200);
+  tape.equal(result.headers["content-type"], "application/json;charset=utf-8");
+  checkBundleResponse(tape, result.data);
+});
+
+test("'/bundle/:name' should return an error if it fails", async(tape) => {
+  tape.plan(2);
+  const wrongPackageName = "br-br-br-brah";
+
+  try {
+    await get(new URL(`/bundle/${wrongPackageName}`, HTTP_URL));
+  }
+  catch (error) {
+    tape.equal(error.statusCode, 404);
+    tape.equal(error.data.error, "Not Found");
+  }
+
+  tape.end();
+});
+
 test("teardown", (tape) => {
   httpServer.server.close();
   tape.end();
 });
+
+/**
+ * HELPERS
+ */
+
+function checkBundleResponse(tapeInstance, payload) {
+  tapeInstance.ok(payload.gzip);
+  tapeInstance.ok(payload.size);
+  tapeInstance.ok(payload.dependencySizes);
+}