Skip to content

Commit 984ae23

Browse files
Merge pull request #5090 from OAI/v3.2-dev-sync-with-dev
v3.2-dev: sync with dev
2 parents 882f4d6 + 27f02ad commit 984ae23

File tree

7 files changed

+71
-85
lines changed

7 files changed

+71
-85
lines changed

.github/workflows/check-restricted-files.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ jobs:
4646
4747
echo This PR contains changes to files that should not be changed:
4848
echo
49-
git diff --compact-summary origin/${{ github.event.pull_request.base.ref }} origin/${{ github.event.pull_request.head.ref }} -- versions/
49+
git diff --compact-summary origin/${{ github.event.pull_request.base.ref }} -- versions/
5050
5151
exit 1

.github/workflows/sync-dev-to-vX.Y-dev.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ jobs:
4545
4646
git checkout -b $SYNC origin/$SYNC || git checkout -b $SYNC origin/$BASE
4747
git merge origin/$HEAD -m "Merge $HEAD into $SYNC"
48-
git checkout origin/$BASE src/*
49-
git checkout origin/$BASE tests/*
50-
git commit -m "Restored src/* and tests/*" || echo ""
48+
git checkout origin/$BASE src/
49+
git checkout origin/$BASE tests/schema/
50+
git commit -m "Restored src/ and tests/schema/" || echo ""
5151
git push -u origin $SYNC
5252
5353
EXISTS=$(gh pr list --base $BASE --head $SYNC \

.github/workflows/sync-main-to-dev.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ jobs:
4141
4242
git checkout -b $SYNC origin/$SYNC || git checkout -b $SYNC origin/$BASE
4343
git merge origin/$HEAD -m "Merge $HEAD into $SYNC"
44-
git checkout origin/$BASE src/*
45-
git checkout origin/$BASE tests/*
46-
git commit -m "Restored src/* and tests/*" || echo ""
44+
git checkout origin/$BASE src/
45+
git checkout origin/$BASE tests/schema/
46+
git commit -m "Restored src/ and tests/schema/" || echo ""
4747
git push -u origin $SYNC
4848
4949
EXISTS=$(gh pr list --base $BASE --head $SYNC \

CONTRIBUTING.md

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -371,9 +371,9 @@ For information on the branch and release strategy for OAS 3.0.4 and 3.1.1 and e
371371

372372
* `main` is used to publish finished work and hold the authoritative versions of general documentation such as this document, which can be merged out to other branches as needed. The `src` tree is _**not**_ present on `main`.
373373
* `dev` is the primary branch for working with the `src` tree. Development infrastructure that is not needed on `main` is maintained here, and can be merged out to other non-`main` branches as needed.
374-
Changes on `main` are automatically included in a pull request to `dev` (see the (section on [branch sync](#branch-sync-automation)).
374+
Changes on `main` are automatically included in a pull request to `dev` (see the section on [branch sync](#branch-sync-automation)).
375375
* `vX.Y-dev` is the minor release line development branch for X.Y, including both the initial X.Y.0 minor version and all subsequent X.Y.Z patch versions. All PRs are made to oldest active `vX.Y-dev` branch to which the change is relevant, and then merged forward as shown in the diagram further down in this document.
376-
* `vX.Y.Z-rel` is the release branch for an X.Y.Z release (including when Z == 0). It exists primarily for `git mv`-ing `src/oas.md` to the appropriate `versions/X.Y.Z.md` location and removing schema-related files before merging back to `main`, and can also be used for any emergency post-release fixes that come up, such as when a 3rd party changes URLs in a way that breaks published links.
376+
* `vX.Y.Z-rel` is the release branch for an X.Y.Z release (including when Z == 0). It exists primarily for `git mv`-ing `src/oas.md` to the appropriate `versions/X.Y.Z.md` location and removing schema-related files before merging back to `main`, and is deleted once merged into `main` via a pull request.
377377

378378
### Branching and merging (3.1.2, 3.2.0, and later)
379379

@@ -403,14 +403,14 @@ config:
403403
git2: "#eedd88"
404404
git3: "#ccbb66"
405405
git4: "#aa9944"
406-
git5: "#887722"
407-
git6: "#99ccff"
408-
git7: "#77aadd"
406+
git5: "#44ff77"
407+
git6: "#22cc22"
408+
git7: "#11aa11"
409409
gitBranchLabel1: "#000000"
410410
gitBranchLabel2: "#000000"
411411
gitBranchLabel3: "#000000"
412412
gitBranchLabel4: "#000000"
413-
gitBranchLabel5: "#ffffff"
413+
gitBranchLabel5: "#000000"
414414
gitBranchLabel6: "#000000"
415415
gitBranchLabel7: "#000000"
416416
---
@@ -425,9 +425,8 @@ gitGraph TB:
425425
commit id:"update version in src/oas.md to 3.2.0"
426426
commit id:"some 3.2.0 work"
427427
checkout v3.1-dev
428-
commit id:"a 3.1.x fix"
429-
checkout v3.2-dev
430-
merge v3.1-dev id:"merge 3.1.2 fixes"
428+
commit id:"a 3.1.2 fix"
429+
431430
checkout v3.1-dev
432431
branch v3.1.2-rel order:3
433432
commit id:"rename src/oas.md to versions/3.1.2.md"
@@ -444,10 +443,9 @@ gitGraph TB:
444443
commit id:"more 3.2.0 work"
445444
checkout v3.1-dev
446445
commit id:"update version in src/oas.md to 3.1.3"
447-
commit id:"another 3.1.x fix"
446+
commit id:"a 3.1.3 fix"
448447
checkout v3.2-dev
449448
commit id:"still more 3.2.0 work"
450-
merge v3.1-dev id:"merge 3.1.3 fixes before releasing"
451449
452450
checkout v3.1-dev
453451
branch v3.1.3-rel order:4
@@ -476,30 +474,18 @@ gitGraph TB:
476474
477475
checkout v3.2-dev
478476
branch v3.3-dev order:9
479-
checkout v3.1-dev
480-
commit id:"update version in src/oas.md to 3.1.4"
481477
checkout v3.2-dev
482478
commit id:"update version in src/oas.md to 3.2.1"
483479
checkout v3.3-dev
484480
commit id:"update version in src/oas.md to 3.3.0"
485481
486-
checkout v3.1-dev
487-
commit id:"a 3.1.4 fix"
488482
checkout v3.2-dev
489483
commit id:"a 3.2.1 fix"
490-
merge v3.1-dev id:"merge 3.1.4 fixes before releasing"
491-
checkout v3.3-dev
492-
merge v3.2-dev id:"merge 3.1.4 / 3.2.1 fixes"
493484
494-
checkout v3.1-dev
495-
branch v3.1.4-rel order:5
496-
commit id:"rename src/oas.md to versions/3.1.4.md"
497485
checkout v3.2-dev
498486
branch v3.2.1-rel order:8
499487
commit id:"rename src/oas.md to versions/3.2.1.md"
500488
501-
checkout main
502-
merge v3.1.4-rel tag:"3.1.4"
503489
checkout dev
504490
merge main id:" auto-sync from main"
505491
checkout v3.1-dev
@@ -534,7 +520,7 @@ To keep changes in sync, we have some GitHub actions that open pull requests to
534520
- `sync-dev-to-vX.Y-dev` opens pull requests with all the changes from `dev` that aren't yet included on the corresponding `vX.Y-dev` branch. These pull requests are automatically merged if all required status checks pass.
535521

536522
The aim is to bring build script and repository documentation changes to the other branches.
537-
Published versions of the specifications and schemas will also move across branches with this approach.
523+
Published versions of the specifications will also move across branches with this approach.
538524

539525
## Appendix: Issue Automation
540526

package-lock.json

Lines changed: 48 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"devDependencies": {
3030
"@hyperjump/json-schema-coverage": "^1.1.2",
3131
"@umbrelladocs/linkspector": "^0.4.7",
32-
"@vitest/coverage-v8": "^4.0.4",
32+
"@vitest/coverage-v8": "^4.0.5",
3333
"c8": "^10.1.3",
3434
"markdownlint-cli2": "^0.18.1",
3535
"vitest": "^4.0.1",

vitest.config.mjs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ export default defineConfig({
88
coverage: {
99
include: ["src/schemas/validation/**/*.yaml"],
1010
thresholds: process.env.BASE !== "dev" ? {
11-
statements: 99.42, // should be 100% but we are missing some tests
12-
lines: 99.42, // should be 100% but we are missing some tests
13-
functions: 92.58, // should be 100% but we are missing some tests
14-
// branches: 56.77, // need to discuss whether we should check/increase this
11+
statements: 100, // JSON Schema keywords
12+
lines: 100,
13+
// functions: 100, // subschemas, for example with `properties` - to be discussed
14+
// branches: 56.77, // branch coverage isn't that useful
1515
} : {}
1616
},
1717
forceRerunTriggers: ['**/scripts/**', '**/tests/**'],
18-
testTimeout: 10000, // 10 seconds
18+
testTimeout: 20000, // 20 seconds, sometimes needed on slower machines
1919
},
2020
})

0 commit comments

Comments
 (0)