Potential lost data on account payment order migration

[lorenzoallegrucci]

Module

account_payment_order

Describe the bug

After this commit 4c9020f
account_payment records are not created due for account payment state not in ('uploaded', 'done') loosing data!!

The same problem is on 14->15 migration:
https://github.com/OCA/bank-payment/blob/15.0/account_payment_order/migrations/15.0.2.0.0/post-migration.py#L35

To Reproduce

Affected versions:

• 14.0
• 15.0

Steps to reproduce the behavior:

1. migrate from <= 13.0 to >= 14.0

Expected behavior
not loosing data

Additional context
Add any other context about the problem here. (e.g. OS, Python version, ...)

[lorenzoallegrucci]

@etobella can you explain better this critical commit 4c9020f ?
Thank you

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

[etobella]

The system was duplicating the moves if you had the no_generate_payment marked.