[MIG] project_template: Migration to 18.0

* Change the way to copy end dates to tasks due to api change to _map_tasks_default_values which now longer gets passed the task
* Refactor tests to use setUpClass (finally)
* Update overwritten action context with upstream changes
* Remove originally unmodified (but now outdated) fields from overwritten action
* Update kanban element selector

Author: StefanRijnhart

project_template/__manifest__.py

@@ -7,7 +7,7 @@
     "author": "Patrick Wilson, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/project",
     "category": "Project Management",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "depends": ["project"],
     "data": ["views/project.xml"],

project_template/models/project.py

@@ -30,15 +30,6 @@ def create_project_from_template(self):
             "type": "ir.actions.act_window",
         }
 
-    @api.model
-    def _map_tasks_default_valeus(self, task, project):
-        defaults = super()._map_tasks_default_valeus(task, project)
-        if self.env.context.get(TASK_DEFAULT_COPY_CONTEXT_KEY):
-            # date_end normally is not copied on tasks when a project is
-            # copied, but we want it when generating from template
-            defaults["date_end"] = task.date_end
-        return defaults
-
     # ADD "(TEMPLATE)" TO THE NAME WHEN PROJECT IS MARKED AS A TEMPLATE
     @api.onchange("is_template")
     def on_change_is_template(self):

project_template/models/project_task.py

@@ -7,6 +7,14 @@
 class ProjectTask(models.Model):
     _inherit = "project.task"
 
+    def copy_data(self, default=None):
+        # Propagate task end dates when creating a project from a template
+        vals_list = super().copy_data(default=default)
+        if self.env.context.get(TASK_DEFAULT_COPY_CONTEXT_KEY):
+            for task, vals in zip(self, vals_list, strict=True):
+                vals["date_end"] = task.date_end
+        return vals_list
+
     def update_date_end(self, stage_id):
         # Refuse to overwrite date_end when we are copying a template
         if self.env.context.get(TASK_DEFAULT_COPY_CONTEXT_KEY):

project_template/tests/test_project_template.py

@@ -2,26 +2,27 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 from datetime import datetime, timedelta
 
-from odoo.tests import common
+from odoo.addons.base.tests.common import BaseCommon
 
 
-class TestProjectTemplate(common.TransactionCase):
-    def setUp(self):
-        super().setUp()
-        self.test_customer = self.env["res.partner"].create({"name": "TestCustomer"})
-        self.test_project = self.env["project.project"].create(
+class TestProjectTemplate(BaseCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.test_customer = cls.env["res.partner"].create({"name": "TestCustomer"})
+        cls.test_project = cls.env["project.project"].create(
             {
                 "name": "TestProject",
                 "alias_name": "test_alias",
-                "partner_id": self.test_customer.id,
+                "partner_id": cls.test_customer.id,
             }
         )
-        self.tasks = [
-            self.env["project.task"].create(
-                {"name": "TestTask", "project_id": self.test_project.id}
+        cls.tasks = [
+            cls.env["project.task"].create(
+                {"name": "TestTask", "project_id": cls.test_project.id}
             ),
-            self.env["project.task"].create(
-                {"name": "TestTask2", "project_id": self.test_project.id}
+            cls.env["project.task"].create(
+                {"name": "TestTask2", "project_id": cls.test_project.id}
             ),
         ]
 

project_template/views/project.xml

@@ -26,10 +26,7 @@
         <field name="model">project.project</field>
         <field name="inherit_id" ref="project.view_project_kanban" />
         <field name="arch" type="xml">
-            <xpath
-                expr="//div[hasclass('o_kanban_card_manage_section')]"
-                position="inside"
-            >
+            <xpath expr="//div[@name='card_menu_view']" position="inside">
                 <field name="is_template" invisible="1" />
                 <div t-if="record.is_template.raw_value" role="menuitem">
                     <a
@@ -61,13 +58,10 @@
             </filter>
         </field>
     </record>
+    <!-- Add default filter on non-templates -->
     <record model="ir.actions.act_window" id="project.open_view_project_all">
-        <field name="name">Projects</field>
-        <field name="res_model">project.project</field>
-        <field name="view_id" ref="project.view_project_kanban" />
-        <field name="view_mode">kanban,form,tree</field>
         <field
             name="context"
-        >{"search_default_projects":1, "search_default_not_closed":1}</field>
+        >{"display_milestone_deadline": True, "search_default_projects": True}</field>
     </record>
 </odoo>