Skip to content

[18.0][MIG] fastapi_auth_jwt: Migration to 18.0 #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] fastapi_auth_jwt: Migration to 18.0 #490

wants to merge 13 commits into from

Conversation

@dnplkndll
Copy link

@dnplkndll dnplkndll commented Jan 16, 2025 •
edited
Loading

@dnplkndll dnplkndll changed the title 18.0 mig fastapiauth_jwt [18.0][MIG] fastapiauth_jwt Jan 16, 2025
@dnplkndll dnplkndll changed the title [18.0][MIG] fastapiauth_jwt [18.0][MIG] fastapi_auth_jwt Jan 16, 2025
@dnplkndll dnplkndll changed the title [18.0][MIG] fastapi_auth_jwt [18.0][MIG] fastapi_auth_jwt: Migration to 18.0 Jan 16, 2025
@dnplkndll dnplkndll force-pushed the 18.0-mig-fastapi_auth_jwt0 branch 4 times, most recently from 26f6aac to 3924b66 Compare January 16, 2025 23:57
@dnplkndll
Copy link
Author

@sbidoul I am stumped
3924b66
how do you troubleshoot the dependency error?

@lmignon
Copy link
Contributor

lmignon commented Jan 17, 2025

/ocabot migration fastapi_auth_jwt

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 17, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 17, 2025
Open
18 tasks
@dnplkndll dnplkndll force-pushed the 18.0-mig-fastapi_auth_jwt0 branch from b9a8abf to 0ec27f7 Compare February 1, 2025 18:46
@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt0 branch 4 times, most recently from 0a6830a to c24ed0d Compare April 2, 2025 05:47
@kobros-tech kobros-tech mentioned this pull request Apr 2, 2025
Open
3 tasks
@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt0 branch from c24ed0d to f8b16df Compare April 2, 2025 06:05
TomAlbrechtQuatra
TomAlbrechtQuatra reviewed Apr 2, 2025
View reviewed changes
fastapi_auth_jwt/dependencies.py Outdated
request, response, authorization_header, validator
)
uid = validator._get_and_check_uid(payload)
return odoo_env(user=uid)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return odoo_env(user=uid)
return env(user=uid)

@dnplkndll small error here. Thanks for the migration!

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt0 branch from f8b16df to fb0efca Compare April 3, 2025 12:07
@dnplkndll dnplkndll force-pushed the 18.0-mig-fastapi_auth_jwt0 branch 2 times, most recently from eda94c4 to cc37270 Compare April 11, 2025 00:53
@grindtildeath grindtildeath mentioned this pull request Jun 16, 2025
Merged
grindtildeath
grindtildeath approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@grindtildeath
Copy link
Contributor

@dnplkndll Can you please rebase? 🙏

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt0 branch from cc37270 to 216ee2a Compare June 17, 2025 11:05
@kobros-tech
Copy link

@grindtildeath

the conflict is resolved and code is fine now.

@yvaucher
Copy link
Member

@kobros-tech As you reacted here, I suppose this superseeds your PR #483 ?

@yvaucher yvaucher mentioned this pull request Jul 28, 2025
Closed
@kobros-tech
Copy link

@kobros-tech As you reacted here, I suppose this superseeds your PR #483 ?

yes, I run both and compare them to each other to see which approach is the best.
Thank you!

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt0 branch from 216ee2a to e64c838 Compare August 25, 2025 02:08
@kobros-tech
Copy link

@TomAlbrechtQuatra
@yvaucher

how do you think now?

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt0 branch from e64c838 to b1a63a2 Compare August 31, 2025 18:20
@kobros-tech
Copy link

@lmignon
@sbidoul

The PR is clean and ready now for migration merge?

lmignon
lmignon reviewed Sep 1, 2025
View reviewed changes
extendable/tests/common.py

from contextlib import contextmanager

import odoo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendable should not be modified

lmignon
lmignon requested changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for the migration @dnplkndll
Can you add the code from #402. This fix is missing into the migrated code.

@kobros-tech
Copy link

@lmignon
Thank you too, we love community open source cooperation :)

@kobros-tech
Copy link

@lmignon
Shall I add your fix commit to the demo module?
fastapi_auth_jwt_demo/tests/test_fastapi_auth_jwt_demo.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon requested changes

+2 more reviewers

@TomAlbrechtQuatra TomAlbrechtQuatra TomAlbrechtQuatra left review comments

@grindtildeath grindtildeath grindtildeath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

9 participants

@dnplkndll @lmignon @grindtildeath @kobros-tech @yvaucher @TomAlbrechtQuatra @OCA-git-bot @sbidoul @qgroulard