GridKit interface with IDA can't return values

[Paulm991]

Tests that are constantly collecting data over time don't have an easy way to obtain this data from the Ida.cpp file. To measure responses from perturbations, it is nice to be able to get the data generated at each time step.

In my tests on the genrou-test-2 branch, I used a callback function that returned the timestep and y vector after every time step. This was used by the GenrouTest.cpp file to print out each y value to a file.

[pelesh]

CC @alexander-novo @reid-g @abdourahmanbarry

[alexander-novo]

Is the linked pull request still applicable?

[pelesh]

Is the linked pull request still applicable?

I think we have better solutions already available in the develop branch, but the linked pull request is also a helpful reference imho. We need to decide what callbacks to implement and/or keep in Ida class. For example, we might want to add a "mask" to the callback method to select only the needed outputs.

[alexander-novo]

As it is right now, these functions aren't used anywhere:

void printOutput(sunrealtype t);
void printSpecial(sunrealtype t, N_Vector x);

And aren't really "callbacks" - they are not automatically called by anything. As I see it, I think these functions are probably useless since these values can be queried from the underlying model rather than the integrator buffer, and should probably be removed?

The functionality implemented by printOutputF is specific to the PhasorDynamics/Example1 example, so that function should probably be moved to that example rather than the IDA wrapper, and a more generic callback system (such as implemented in #91) should be used to call it.

Finally, for printFinalStats: it also isn't really a callback but more a query for internal IDA statistics. It could probably be redesigned somewhat but I don't think it can be made any more generic.