Skip to content

Document PhasorDynamics::Genrou model #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pelesh opened this issue Apr 5, 2025 · 0 comments · May be fixed by #88
Open

Document PhasorDynamics::Genrou model #79

pelesh opened this issue Apr 5, 2025 · 0 comments · May be fixed by #88
Assignees
@abirchfield
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@pelesh
Copy link
Collaborator

pelesh commented Apr 5, 2025

There are slight differences between documentation for the PhasorDynamics::Genrou model and its current implementation. It would be helpful to update README file for the PhasorDynamics::Genrou model to match precisely the equations as coded.

Also, it would be helpful to review documentation for the generic synchronous machine model and remove any duplication with Genrou docs, just to avoid any confusion.
@pelesh pelesh added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 5, 2025
@pelesh pelesh mentioned this issue Apr 5, 2025
Merged
@lukelowry lukelowry linked a pull request Apr 22, 2025 that will close this issue
Open
@lukelowry lukelowry linked a pull request Apr 22, 2025 that will close this issue
Lukel/phasor docs #88
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abirchfield abirchfield

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lukel/phasor docs ORNL/GridKit
2 participants
@abirchfield @pelesh