Skip to content

Permanently enable filename sanitizer #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janhalen opened this issue May 12, 2025 · 4 comments
Open

Permanently enable filename sanitizer #175

janhalen opened this issue May 12, 2025 · 4 comments

Comments

@janhalen
Copy link

janhalen commented May 12, 2025

In os2forms_digital_post os2forms_attachment the filename sanitizer option should be enabled permanently and there should be no option to disable it.

Some research should be made whether the built-in sanitazion matches the criteria from Digitaliseringsstyrelsen (described at the bottom of this doc: https://digitaliser.dk/digital-post/vejledninger/tilladte-filtyper-og-navne) or if some additional filters should be added to match the criteria from Digitaliseringstyrelsen.

@janhalen
Copy link
Author

@jekuaitk & @rimi-itk: Please correct or add to this issue if i missed something...

@jekuaitk
Copy link
Contributor

The discussed sanitation changes should be made to os2forms_attachment.

In the os2forms_digital_post handler webform builders configure which element contains the attachment that should be sent via Digital Post. This can either be a

as seen in here.

As a sidenote i think we should consider only allowing the os2forms_attachment but that is for another time.

Both attachment elements use the mentioned Drupal built-in sanitization, since os2forms_attachment uses the webform webform_entity_print_attachment as a base.

@janhalen
Copy link
Author

@jekuaitk : modulename corrected in issue description

@janhalen
Copy link
Author

As a sidenote i think we should consider only allowing the os2forms_attachment but that is for another time.

@jekuaitk: When you have the time you could create an issue for this and describe the rationale so that the coordination comittee and @ChatBotBerg is aware of an pending work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants