Skip to content

Commit cb08359

Browse files
author
Barbara Post
committed
Deleted unmaintained .ts file, updated to ionic 1.1.0, integrated domiSchenk#2
1 parent bb76bbb commit cb08359

File tree

5 files changed

+53
-106
lines changed

5 files changed

+53
-106
lines changed

.gitignore

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,38 @@
1-
# Windows image file caches
2-
Thumbs.db
3-
ehthumbs.db
4-
5-
# Folder config file
6-
Desktop.ini
7-
8-
# Recycle Bin used on file shares
9-
$RECYCLE.BIN/
10-
11-
# Windows Installer files
12-
*.cab
13-
*.msi
14-
*.msm
15-
*.msp
16-
17-
# =========================
18-
# Operating System Files
19-
# =========================
20-
21-
# OSX
22-
# =========================
23-
1+
# Windows image file caches
2+
Thumbs.db
3+
ehthumbs.db
4+
5+
# Folder config file
6+
Desktop.ini
7+
8+
# Recycle Bin used on file shares
9+
$RECYCLE.BIN/
10+
11+
# Windows Installer files
12+
*.cab
13+
*.msi
14+
*.msm
15+
*.msp
16+
17+
# =========================
18+
# Operating System Files
19+
# =========================
20+
21+
# OSX
22+
# =========================
23+
2424
.DS_Store
2525
.AppleDouble
2626
.LSOverride
2727

2828
# Icon must ends with two \r.
29-
Icon
29+
Icon
30+
3031

3132
# Thumbnails
3233
._*
3334

3435
# Files that might appear on external disk
3536
.Spotlight-V100
3637
.Trashes
38+
.idea/

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,14 @@ ionic-Select-Control
33

44
Select Box created with Ionic modal and ionic-list
55

6-
## New fork
6+
## New fork by postb99 notes
7+
78
**09/28/2015 :** forked from **dslack** to integrate ASAP the 2 pull requests listed here on original **domischenk** project :
89
https://github.com/domiSchenk/ionic-Select-Control/pulls
910

10-
##Changes
11+
**09/29/2015 :** work in progress, test and handle optionality of ngSelectChanged new attribute.
12+
13+
## Changes
1114

1215
Added Header class support to better integrate with apps
1316

src/SelectBox.js

Lines changed: 11 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/SelectBox.ts

Lines changed: 0 additions & 74 deletions
This file was deleted.

test/index.html

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
<meta charset="utf-8">
55
<meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width">
66
<title></title>
7-
<link href="http://code.ionicframework.com/1.0.0/css/ionic.css" rel="stylesheet">
7+
<link href="http://code.ionicframework.com/1.1.0/css/ionic.css" rel="stylesheet">
88
<link href="../src/SelectBox.css" rel="stylesheet">
99
<!-- ionic/angularjs js -->
10-
<script src="http://code.ionicframework.com/1.0.0/js/ionic.bundle.min.js"></script>
10+
<script src="http://code.ionicframework.com/1.1.0/js/ionic.bundle.min.js"></script>
1111

1212
<script src="../src/SelectBox.js"></script>
1313

@@ -19,15 +19,22 @@
1919
ng-title="List Value"
2020
ng-data="list"
2121
ng-placeholder="Select"
22-
ng-header-class="bar-calm"></select-box>
22+
ng-header-class="bar-calm"
23+
ng-select-changed="onSelectChanged()"
24+
></select-box>
2325

2426
<script>
2527
angular.module('ionicApp', ['ionic', '$selectBox'])
2628
.controller('MyCtrl', function($scope){
2729
$scope.list = [
2830
{key:"Test", label:"Test Label"},
29-
{key:"Test 2", label: "Test Label 2"}
31+
{key:"Test2", label: "Test Label 2"}
3032
];
33+
34+
$scope.onSelectChanged = function() {
35+
//alert('You changed value to: ' + $scope.selectedItemId);
36+
alert('You changed value to: ' + $scope.myObj);
37+
};
3138
});
3239
</script>
3340
</body>

0 commit comments

Comments
 (0)