Skip to content

Commit dd77bdd

Browse files
committed
replace unique uid constraint for unique together with added_by
1 parent 30eb9ca commit dd77bdd

File tree

3 files changed

+34
-3
lines changed

3 files changed

+34
-3
lines changed
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Generated by Django 2.0.9 on 2018-11-29 11:35
2+
3+
from django.conf import settings
4+
from django.db import migrations, models
5+
6+
7+
class Migration(migrations.Migration):
8+
9+
dependencies = [
10+
migrations.swappable_dependency(settings.AUTH_USER_MODEL),
11+
('supervise', '0014_auto_20180307_1417'),
12+
]
13+
14+
operations = [
15+
migrations.AlterField(
16+
model_name='blacklisteduser',
17+
name='uid',
18+
field=models.CharField(max_length=255),
19+
),
20+
migrations.AlterUniqueTogether(
21+
name='blacklisteduser',
22+
unique_together={('uid', 'added_by')},
23+
),
24+
]

osmchadjango/supervise/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class Meta:
5353

5454
class BlacklistedUser(models.Model):
5555
username = models.CharField(max_length=1000)
56-
uid = models.CharField(max_length=255, unique=True)
56+
uid = models.CharField(max_length=255)
5757
added_by = models.ForeignKey(User, on_delete=models.CASCADE)
5858
date = models.DateTimeField(auto_now_add=True)
5959

@@ -65,4 +65,5 @@ def save(self, *args, **kwargs):
6565
super(BlacklistedUser, self).save(*args, **kwargs)
6666

6767
class Meta:
68+
unique_together = ('uid', 'added_by')
6869
ordering = ['-date']

osmchadjango/supervise/tests/test_models.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,8 @@ def test_other_geometry_types(self):
149149

150150
class TestBlacklistedUserModel(TestCase):
151151
def setUp(self):
152-
self.user = UserFactory(is_staff=True)
152+
self.user = UserFactory()
153+
self.other_user = UserFactory()
153154
self.blacklisted = BlacklistedUser.objects.create(
154155
username='Bad User',
155156
uid='3434',
@@ -187,4 +188,9 @@ def test_validation(self):
187188
uid='5643',
188189
added_by=self.user,
189190
)
190-
self.assertEqual(BlacklistedUser.objects.count(), 2)
191+
BlacklistedUser.objects.create(
192+
username='Bad User',
193+
uid='5643',
194+
added_by=self.other_user,
195+
)
196+
self.assertEqual(BlacklistedUser.objects.count(), 3)

0 commit comments

Comments
 (0)