Skip to content

Commit c2fbf4a

Browse files
authored
Fix display of RTL tag and role values in element info table (#790)
1 parent 480e594 commit c2fbf4a

File tree

1 file changed

+34
-14
lines changed

1 file changed

+34
-14
lines changed

src/components/element_info.js

+34-14
Original file line numberDiff line numberDiff line change
@@ -259,32 +259,46 @@ function TagsTable({ action }) {
259259
if (oldval === newval) {
260260
return (
261261
<tr>
262-
<td>{key}</td>
263-
<td>{newval}</td>
262+
<td>
263+
<span dir="auto">{key}</span>
264+
</td>
265+
<td>
266+
<span dir="auto">{newval}</span>
267+
</td>
264268
</tr>
265269
);
266270
} else if (oldval === undefined) {
267271
return (
268272
<tr className="create">
269-
<td>{key}</td>
270-
<td>{newval}</td>
273+
<td>
274+
<span dir="auto">{key}</span>
275+
</td>
276+
<td>
277+
<span dir="auto">{newval}</span>
278+
</td>
271279
</tr>
272280
);
273281
} else if (newval === undefined) {
274282
return (
275283
<tr className="delete">
276-
<td>{key}</td>
277-
<td>{oldval}</td>
284+
<td>
285+
<span dir="auto">{key}</span>
286+
</td>
287+
<td>
288+
<span dir="auto">{oldval}</span>
289+
</td>
278290
</tr>
279291
);
280292
} else {
281293
return (
282294
<tr className="modify">
283-
<td>{key}</td>
284295
<td>
285-
<del>{oldval}</del>
296+
<span dir="auto">{key}</span>
297+
</td>
298+
<td>
299+
<del dir="auto">{oldval}</del>
286300
{' → '}
287-
<ins>{newval}</ins>
301+
<ins dir="auto">{newval}</ins>
288302
</td>
289303
</tr>
290304
);
@@ -332,31 +346,37 @@ function RelationMembersTable({ action, setHighlight }) {
332346
return (
333347
<tr {...interactions}>
334348
<td>{id}</td>
335-
<td>{newrole}</td>
349+
<td>
350+
<span dir="auto">{newrole}</span>
351+
</td>
336352
</tr>
337353
);
338354
} else if (oldrole === undefined) {
339355
return (
340356
<tr className="create" {...interactions}>
341357
<td>{id}</td>
342-
<td>{newrole}</td>
358+
<td>
359+
<span dir="auto">{newrole}</span>
360+
</td>
343361
</tr>
344362
);
345363
} else if (newrole === undefined) {
346364
return (
347365
<tr className="delete" {...interactions}>
348366
<td>{id}</td>
349-
<td>{oldrole}</td>
367+
<td>
368+
<span dir="auto">{oldrole}</span>
369+
</td>
350370
</tr>
351371
);
352372
} else {
353373
return (
354374
<tr className="modify" {...interactions}>
355375
<td>{id}</td>
356376
<td>
357-
<del>{oldrole}</del>
377+
<del dir="auto">{oldrole}</del>
358378
{' → '}
359-
<ins>{newrole}</ins>
379+
<ins dir="auto">{newrole}</ins>
360380
</td>
361381
</tr>
362382
);

0 commit comments

Comments
 (0)